Page MenuHomePhabricator

Generalise CapsuleMultiselectWidget and CheckboxMultiselectWidget into a MultiselectWidget
Closed, DeclinedPublic

Event Timeline

Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a project: OOUI.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
matmarex renamed this task from Generalise CapsuleMultiSelectWidget into a MultiSelectWidget to Generalise CapsuleMultiselectWidget into a MultiselectWidget.May 19 2016, 6:38 PM
matmarex set Security to None.

I thought about this quite a bit when working on T117782. I feel that the current CapsuleMultiselectWidget is unsalvageable, it seemed very difficult to reconcile a sensible API for a multiselect widget with allowing the user to add new options at will and using the dropdown menu as the master list of available ones.

If anyone plans to work on this, I'd suggest:

  1. Scrap the current CapsuleMultiselectWidget/CapsuleItemWidget entirely, except for the styling
  2. Implement two new pairs of classes:
    • CapsuleGroupWidget/CapsuleWidget, which would allow users to insert arbitrary options, and which would support the fancy popup things
    • CapsuleMultiselectWidget/CapsuleMultioptionWidget, which would allow users to select some predefined options from many
Prtksxna renamed this task from Generalise CapsuleMultiselectWidget into a MultiselectWidget to Generalise CapsuleMultiselectWidget and CheckboxMultiselectWidget into a MultiselectWidget.Jul 8 2016, 1:05 PM

@matmarex @Mooeypoo Is this something you want to consider for TagMultiselectWidget or should we decline this task?

This came up before the design and implementation of TagMultiselectWidget and MenuTagMultiselectWidget, which are more or less answering the basic request. Unless there's an additional request here, I think we can close this task as either declined or completed.

As per @Mooeypoo above. Use TagMultiselect- or MenuTagMultiselectWidget. Declined for CapsuleMultiselectWidget as per T183299: Replace and deprecate CapsuleMultiselectWidget.