Page MenuHomePhabricator
Create Task
Maniphest T108595

In an indented list, enter/return in a blank terminal li should move to a new li in the parent list, not a <p> in the current one
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

This may be related to T108357: Line breaks pasted as <br>s in Firefox.

Steps to reproduce:

  1. Type a new list:
* Food
** Apples
** Blueberries
** Cherries
  1. Then press Return (get a new "** list item") and Return again (get a new paragraph[1]). Type a new paragraph.
  1. Notice that the "new paragraph" is not properly aligned. The first character is aligned with the first character of the level-one list item, rather than on the left margin where it belongs.
  1. Save the page. Check the diff. The last item is ** List item new paragraph when it ought to be
** List item
New paragraph

[1] Why didn't pressing Return again un-indent to a "* list item"?

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (8d1c0d026)mediawiki/extensions/VisualEditormaster+2 -1
LinearEnterKeyDownHandler: Enter behavior in nested listsVisualEditor/VisualEditormaster+54 -5
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Aug 10 2015, 5:13 PM
• Whatamidoing-WMF raised the priority of this task from to Needs Triage.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added projects: VisualEditor, Parsoid.
• Whatamidoing-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2015, 5:13 PM
Jdforrester-WMF renamed this task from Paragraph after a list was added to the last list item to In an indented list, enter/return in a blank terminal li should move to a new li in the parent list, not a <p> in the current one.Aug 10 2015, 8:19 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: VisualEditor-EditingTools.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF removed a project: Parsoid.
Jdforrester-WMF subscribed.

Re-titling to be about the change in VE; I think Parsoid was doing the right thing here given the HTML VE sends.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Aug 11 2015, 7:05 PM
Jdforrester-WMF moved this task from TR1: Releases to TR0: Interrupt on the VisualEditor board.Aug 26 2015, 1:36 AM
gerritbot subscribed.Oct 25 2017, 4:35 PM

Change 386418 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] LinearEnterKeyDownHandler: Enter behavior in nested lists

https://gerrit.wikimedia.org/r/386418

gerritbot added a project: Patch-For-Review.Oct 25 2017, 4:35 PM
gerritbot added a comment.Oct 26 2017, 11:32 AM

Change 386418 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinearEnterKeyDownHandler: Enter behavior in nested lists

https://gerrit.wikimedia.org/r/386418

• Deskana closed this task as Resolved.Oct 26 2017, 12:06 PM
• Deskana assigned this task to DLynch.
• Deskana changed the point value for this task from 1 to 8.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 26 2017, 12:06 PM
gerritbot added a comment.Oct 26 2017, 10:57 PM

Change 386762 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8d1c0d026)

https://gerrit.wikimedia.org/r/386762

gerritbot added a comment.Oct 27 2017, 11:23 AM

Change 386762 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8d1c0d026)

https://gerrit.wikimedia.org/r/386762

Jdforrester-WMF edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)); removed Patch-For-Review.Oct 30 2017, 3:01 PM
Ryasmeen added projects: Verified, Verified-in-Phase0, Verified-in-Phase2.Nov 3 2017, 8:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL