Page MenuHomePhabricator
Create Task
Maniphest T108600

UrlShortener URL input field truncates text
Closed, ResolvedPublic
Actions

Description

See below. The input box does contains the full URL (https://en.wikipedia.org/wiki/Main_Page), but I need to scroll horizontally to see it, even though the input box is wide enough.

Screen Shot 2015-08-10 at 10.29.20.png (552×1 px, 90 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
TextInputWidget: Don't forget to positionLabel() after it's been unsetoojs/uimaster+1 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

ori created this task.Aug 10 2015, 5:31 PM
ori raised the priority of this task from to Medium.
ori updated the task description. (Show Details)
ori added projects: MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup, WMF-General-or-Unknown.
ori added subscribers: Ricordisamoa, tstarling, • Prtksxna and 24 others.
ori added a comment.Aug 10 2015, 5:34 PM

Possible clue: the width of the visible text is the complement of the width of the right-aligned error text that is displayed when the input field is empty.

Screen Shot 2015-08-10 at 10.33.28.png (732×1 px, 106 KB)

Glaisher removed projects: WMF-General-or-Unknown, Wikimedia-Extension-setup.Aug 10 2015, 5:36 PM
Glaisher set Security to None.
ori added projects: OOUI, OOjs core.Aug 11 2015, 8:08 PM

I think it's a bug in OO.ui.TextInputWidget.prototype.positionLabel.

Jdforrester-WMF subscribed.Aug 11 2015, 8:10 PM

Fun.

Jdforrester-WMF removed a project: OOjs core.Aug 11 2015, 8:10 PM
Jorm unsubscribed.Aug 11 2015, 8:12 PM
gerritbot subscribed.Aug 11 2015, 8:31 PM

Change 230915 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Don't forget to positionLabel() after it's been unset

https://gerrit.wikimedia.org/r/230915

gerritbot added a project: Patch-For-Review.Aug 11 2015, 8:31 PM
gerritbot added a comment.Aug 11 2015, 8:41 PM

Change 230915 merged by jenkins-bot:
TextInputWidget: Don't forget to positionLabel() after it's been unset

https://gerrit.wikimedia.org/r/230915

• matmarex mentioned this in rGOJU97c8e47bac4c: TextInputWidget: Don't forget to positionLabel() after it's been unset.Aug 11 2015, 8:41 PM
• matmarex claimed this task.Aug 11 2015, 10:16 PM
Legoktm merged a task: T108568: After an error, URL shortener input field stays narrow..Aug 12 2015, 7:18 AM
Legoktm closed this task as Resolved.Aug 12 2015, 7:23 AM

Fixed after OOUI update (v0.12.3) in MediaWiki core today.

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Aug 26 2015, 1:38 AM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits