Maniphest T108600

UrlShortener URL input field truncates text
Closed, ResolvedPublic
Actions

Tags

Subscribers

gerritbot, Jdforrester-WMF, ori and 24 others

Assigned To

matmarex

Authored By

ori, Aug 10 2015

Description

See below. The input box does contains the full URL (https://en.wikipedia.org/wiki/Main_Page), but I need to scroll horizontally to see it, even though the input box is wide enough.

Details

Related Gerrit Patches:

oojs/ui : master

TextInputWidget: Don't forget to positionLabel() after it's been unset

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ladsgroup	T44085 Wikimedia needs a URL shortener (tracking)
		Resolved		Smalyshev	T112715 Enable different URL shorteners for WDQS
		Resolved		Ladsgroup	T108557 Review and deploy UrlShortener extension to Wikimedia wikis
		Resolved		matmarex	T108600 UrlShortener URL input field truncates text

Event Timeline

ori created this task.Aug 10 2015, 5:31 PM

ori raised the priority of this task from to Medium.

ori updated the task description. (Show Details)

ori added projects: MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup, Wikimedia-General-or-Unknown.

ori added subscribers: Ricordisamoa, tstarling, • Prtksxna and 24 others.

Possible clue: the width of the visible text is the complement of the width of the right-aligned error text that is displayed when the input field is empty.

Glaisher removed projects: Wikimedia-General-or-Unknown, Wikimedia-Extension-setup.Aug 10 2015, 5:36 PM

Glaisher set Security to None.

I think it's a bug in OO.ui.TextInputWidget.prototype.positionLabel.

Fun.

Jdforrester-WMF removed a project: OOjs.Aug 11 2015, 8:10 PM

Jorm removed a subscriber: Jorm.Aug 11 2015, 8:12 PM

Change 230915 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Don't forget to positionLabel() after it's been unset

https://gerrit.wikimedia.org/r/230915

gerritbot added a project: Patch-For-Review.Aug 11 2015, 8:31 PM

Change 230915 merged by jenkins-bot:
TextInputWidget: Don't forget to positionLabel() after it's been unset

https://gerrit.wikimedia.org/r/230915

matmarex mentioned this in rGOJU97c8e47bac4c: TextInputWidget: Don't forget to positionLabel() after it's been unset.Aug 11 2015, 8:41 PM

matmarex claimed this task.Aug 11 2015, 10:16 PM

Legoktm merged a task: T108568: After an error, URL shortener input field stays narrow..Aug 12 2015, 7:18 AM

Fixed after OOUI update (v0.12.3) in MediaWiki core today.

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Aug 26 2015, 1:38 AM

Phabricator_maintenance removed a subscriber: • yuvipanda.Jun 7 2017, 6:48 PM