The WikidataPageBanner extension should be adding image references to the imagelinks and globalimagelinks table. The latter should happen automatically if it is in the imagelinks table.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
WikidataPageBanner add banner to imagelinks | mediawiki/extensions/WikidataPageBanner | master | +16 -0 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Jdlrobson | T102537 Migrating existing templates to new PageBanner extension | |||
Resolved | Jdlrobson | T108839 Configuration changes for English Wikivoyage for WikidataPageBanner | |||
Resolved | Jdlrobson | T108614 Make sure WikidataPageBanner is adding image references to imagelinks table |
Event Timeline
Comment Actions
As I mentioned on IRC, I *think* it needs to use ParserOutput::addImage(), but this is not an area of MW I'm super familiar either.
Comment Actions
Okay great thanks (not sure if Sumit was in IRC at the time). @Sumit let us know if you need any further information.
Comment Actions
As mentioned, @Legoktm gave me a pointer to start from. I'll add a patch for this soon.
Comment Actions
Change 230643 had a related patch set uploaded (by Sumit):
WikidataPageBanner add banner to imagelinks
Comment Actions
As discussed in IRC there is a pending patch and this will be merged prior to the community adopting these templates.
Comment Actions
@brion are you able to help with review on this? Keen to get this fixed and merged asap and I'm sure you of all people will know this code well :)