Ask on engineering list for help.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Awjrichards | T108645 Get code review for Phab burnup reporting scripts (phlogiston) | |||
| Resolved | Ironholds | T110080 Help requested from an R expert to help tweak phlogiston (burnup chart scripts) | |||
| Declined | None | T115740 Simplify Phlogiston R files by moving duplicated code into functions | |||
| Resolved | • JAufrecht | T115743 Replace duplicated R files with parameterized call | |||
| Resolved | • JAufrecht | T110599 Review SQL/Python for Phlogiston |
Event Timeline
Comment Actions
A link to the code would be welcome (assuming it's in a public repository and can be shared publically)
Comment Actions
I was going to write up an ask for the engineering mailing list. Currently the code is in github. I haven't made it through https://www.mediawiki.org/wiki/Gerrit/Tutorial to get it moved to Mediawiki's Git yet; should I do that first?
Comment Actions
Oh I don't know, I guess that's up to you. :)
https://www.mediawiki.org/wiki/Git/New_repositories/Requests is for getting a repository. If wanted.
Comment Actions
@bd808 said he's willing to help with the code review via email communication, @JAufrecht up to you for next steps on moving this forward with @bd808
Comment Actions
I started to look at it, got distracted by something else and never got back to it. I'll make time for it tomorrow.
Comment Actions
Kevin has provided one level of review of Python and SQL. Kevin has provided more potential areas of improvement than I can handle in the near future. However, our #1 concern is that there are no code or design errors that could invalidate the data, and another round of review on this topic would be useful.
Comment Actions
Got enough code review to identify plenty of tech debt. Will make a separate task for a data quality audit.