For the migration to Gadgets 2.0 we need to be able to rename JavaScript and CSS pages without compromising the integrity of module loading. The raw redirect content for JavaScript pages is a mw.loader.load() for the action=raw url, however such request is asynchronous so the module would be ready (and dependants fired) before the actual scripts have been loaded.
Prevent that by making the WikiModule class resolve redirects.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| resourceloader: Follow redirects for JavaScript/CSS in WikiModule | mediawiki/core | master | +69 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T34169 Action to join scripts and styles in one file | |||
| Open | None | T110014 Make gadgets easily customizable (merge Gadgets' branch "gadgetprefs" from GSoC 2011) | |||
| Open | None | T31272 Implement Gadgets 2.0 | |||
| Resolved | Krinkle | T108653 ResourceLoaderWikiModule should follow redirects for JavaScript/CSS content |
Gadgets 2.0 is almost ready to go. Is anyone planning on taking this bug or should I move it to the Community-Tech workboard?
@Krinkle: Where would be the best place to implement the redirect resolving? ResourceLoaderWikiModule::getContent()?
I think so, yes. See MediaWiki.php at https://github.com/wikimedia/mediawiki/blob/d70e36235328c6bd3ddddd0528c94addca4a961a/includes/MediaWiki.php#L429-L440 for similar code.
Untested, but the following should work: WikiPage::factory( Title ), isRedirect(), followRedirect(). Then with the returned Title continue on Revision::newFromTitle in ResourceLoaderWikiModule::getContent() as currently the case. Be sure to guard against non-Title return values (such as strings and booleans) as those external interewiki and specialpage titles, which aren't valid as module content.
@Krinkle: After this bug is solved, will we also need to update the code that creates redirects for JavaScript pages, or is WikiPage::followRedirect() smart enough to deal with that already?
Change 269901 had a related patch set uploaded (by Kaldari):
Make WikiModule class follow redirects for JavaScript/CSS content
When ad9f14d6 added support for redirects to JavaScript pages, it naturally made WikiPage methods for redirect chains etc. work as expected too. Shouldn't need any changing.
Change 269901 merged by jenkins-bot:
[mediawiki/core] resourceloader: Follow redirects for JavaScript/CSS in WikiModule