Maniphest T108686

[Task] Transfer edit comments to client
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Tobi_WMDE_SW
	Aug 11 2015, 2:23 PM

Tags

Referenced Files

None

Subscribers

Description

Edit comments are currently not transferred to the client at all. A "comment" field exists in EntityChange metadata, but it's always empty. We need to put the edit comment into the EntityChange sent to the clients:
EntityChange: drop the $comment field, drop setComment, implement getComment based on getMetadata, plus the fallback logic from the old setComment.
EntityChange: Set 'comment' field in metadata in setMetadataFromRC; Set all metadata (including comment) in setRevisionInfo(); retain comment in setMetadataFromUser().

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Wikibase	master	+189 -91	Record edit summary in Change objects.
	mediawiki/extensions/Wikibase	master	+0 -4	Remove 'comment' from EntityChange::setMetadata validKeys

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T90435 [Epic] Wikidata watchlist improvements (client)
		Open		None	T108688 [Story] meaningful edit summaries on the client
		Resolved		daniel	T108686 [Task] Transfer edit comments to client

Event Timeline

Tobi_WMDE_SW created this task.Aug 11 2015, 2:23 PM

Tobi_WMDE_SW raised the priority of this task from to Medium.

Tobi_WMDE_SW updated the task description. (Show Details)

Tobi_WMDE_SW added projects: Wikidata, Wikidata-Sprint-2015-08-11.

Tobi_WMDE_SW added subscribers: Tobi_WMDE_SW, thiemowmde, • Addshore and 3 others.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2015, 2:23 PM

Lydia_Pintscher added a parent task: T108688: [Story] meaningful edit summaries on the client.Aug 11 2015, 2:38 PM

Ricordisamoa added a subscriber: Ricordisamoa.Aug 13 2015, 4:00 PM

Lydia_Pintscher set Security to None.Aug 14 2015, 10:37 AM

Lydia_Pintscher edited a custom field.

• Addshore renamed this task from Transfer edit comments to client to [Task] Transfer edit comments to client.Aug 14 2015, 3:11 PM

Change 231570 had a related patch set uploaded (by Addshore):
Remove 'comment' from EntityChange::setMetadata validKeys

https://gerrit.wikimedia.org/r/231570

gerritbot added a project: Patch-For-Review.Aug 14 2015, 3:11 PM

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Aug 17 2015, 3:47 PM

Lydia_Pintscher moved this task from Backlog to Doing on the Wikidata-Sprint-2015-08-11 board.Aug 18 2015, 12:57 PM

Lydia_Pintscher added a project: Wikidata-Sprint-2015-08-18.Aug 18 2015, 1:24 PM

JanZerebecki moved this task from Backlog to Doing on the Wikidata-Sprint-2015-08-18 board.Aug 18 2015, 1:26 PM

Change 231570 merged by jenkins-bot:
Remove 'comment' from EntityChange::setMetadata validKeys

https://gerrit.wikimedia.org/r/231570

Diffusion mentioned this in rMEXT4c367944802a: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 19 2015, 9:09 PM

• Addshore mentioned this in rEWBA5a59863f3439: Remove 'comment' from EntityChange::setMetadata validKeys.Aug 19 2015, 9:09 PM

Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Aug 20 2015, 9:08 AM

daniel claimed this task.Aug 21 2015, 10:50 AM

Change 232924 had a related patch set uploaded (by Daniel Kinzler):
Record edit summary in Change objects.

https://gerrit.wikimedia.org/r/232924

daniel moved this task from Doing to Review on the Wikidata-Sprint-2015-08-18 board.Aug 21 2015, 12:38 PM

Change 232924 merged by jenkins-bot:
Record edit summary in Change objects.

https://gerrit.wikimedia.org/r/232924

daniel mentioned this in rMEXT7ce5cd083111: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 25 2015, 11:41 AM

• Addshore mentioned this in rEWBA67a41cfe7401: Record edit summary in Change objects..Aug 25 2015, 11:41 AM

merged

Ricordisamoa removed a project: Patch-For-Review.Aug 28 2015, 4:51 PM

Ricordisamoa removed a subscriber: gerritbot.

Ricordisamoa removed a subscriber: Ricordisamoa.

Ricordisamoa added a subscriber: Ricordisamoa.