Page MenuHomePhabricator

Audio files aren't saved when save a page
Open, LowPublic

Description

Requested in: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8561236

If you save a page, audio files in this page, aren't saved. That should be possible, too.

I'm not sure, if this is really something we should do. Audio files can, potentially, be big, which would take a lot of space on the users device. The bigger problem is, that a user mostly can't know, how much space is needed to save all audio files of an article.

Event Timeline

Florian raised the priority of this task from to Low.
Florian updated the task description. (Show Details)
Florian added subscribers: Krenair, Deskana, Aklapper, Florian.

To me, saving the audio files as well is what intuitively "should" happen (and in some cases, particularly for spoken article files, would be an accessibility win). I'd be in favor of implementing this.

If the total size of the audio files in a page is above a certain threshold, we could display a warning dialog and allow the user to proceed with saving with or without audio files. Also, we could query the free space on the device before saving and display an error message if there isn't enough space available.

This should a lot easier to fix with the new saved page architecture. Just add another parser for anchors, like ImageTagParser, filter out the ones you want, and wire it into PageImageUrlParser.