Go to http://en.wikipedia.beta.wmflabs.org/wiki/Asia and click on the top most banner, the browser goes to the File page.
Expected behaviour: Banner should open in multimediaviewer.
WikidataPageBanner adds its banners to the page manually through a mustache template in BeforePageDisplay hook. @Tgr, Does multimedia viewer add event listeners on images which this banner might be missing? And if yes, is it possible to externally add a listener which would open the viewer?
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/WikidataPageBanner | master | +1 -1 | WikidataPageBanner add class "image" to a:link |
Related Objects
Related Objects
- Mentioned In
- T71456: [Story] Use MediaViewer on commonsMedia properties on Wikibase repo
rEWDP7117d92a66f7: WikidataPageBanner add class "image" to a:link
rMEXT4f19e5c339f4: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataPageBanner… - Mentioned Here
- T77151: Full Zoom Feature in Media Viewer
Event Timeline
Comment Actions
There are multiple issues:
- until MediaViewer gets zoom functionality (T77151) I'm not sure there is a point in using it. It can help with download and such, but it will display the image pretty much the same way it looks on the page.
- you have to make sure the selector used by MediaViewer finds the image
- MediaViewer uses OutputPage::getFileSearchOptions() to decide whether to load on a specific page or not, so you would either have to change that or make sure OutputPage is aware of the image (see the comment here: https://gerrit.wikimedia.org/r/#/c/228751/ )
Comment Actions
Change 230975 had a related patch set uploaded (by Sumit):
WikidataPageBanner add class "image" to a:link
Comment Actions
@Tgr, thanks for the quick feedback, a temporary fix has been implemented, which makes banner image like others open in MultimediaViewer.
Comment Actions
@Tgr, thanks for the quick feedback, a temporary fix has been implemented, which makes banner image like others open in MultimediaViewer.
Comment Actions
Note that it won't work if the page has no other images (and is MediaViewer is not set up).