BadMethodCallException from line 29 of Graph/Graph.body.php: Call to a member function getIsPreview() on a non-object (NULL)
Closed, ResolvedPublic
Actions

Description

this is somewhat frequent in the logs

/w/index.php?title=%E7%89%B9%E5%88%A5:MathShowImage&hash=773282d0f15f7cd9b50ac4b8268c896a&mode=mathml 
BadMethodCallException from line 29 of /srv/mediawiki/php-1.26wmf17/extensions/Graph/Graph.body.php:
Call to a member function getIsPreview() on a non-object (NULL) {
"exception":"
[Exception BadMethodCallException] (/srv/mediawiki/php-1.26wmf17/extensions/Graph/Graph.body.php:29)
Call to a member function getIsPreview() on a non-object (NULL)
[stacktrace]
#0 /srv/mediawiki/php-1.26wmf17/includes/Hooks.php(204): Graph\\Singleton::onParserAfterParse(Parser)
#1 /srv/mediawiki/php-1.26wmf17/extensions/Math/MathTexvc.php(397): Hooks::run(string, array)
#2 /srv/mediawiki/php-1.26wmf17/extensions/Math/SpecialMathShowImage.php(96): MathTexvc->getPng()
#3 /srv/mediawiki/php-1.26wmf17/includes/specialpage/SpecialPage.php(384): SpecialMathShowImage->execute(NULL)
#4 /srv/mediawiki/php-1.26wmf17/includes/specialpage/SpecialPageFactory.php(553): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-1.26wmf17/includes/MediaWiki.php(249): SpecialPageFactory::executePath(Title, RequestContext)
#6 /srv/mediawiki/php-1.26wmf17/includes/MediaWiki.php(677): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.26wmf17/includes/MediaWiki.php(474): MediaWiki->main()
#8 /srv/mediawiki/php-1.26wmf17/index.php(41): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include(string)
#10 {main}
"}

Details

Related Gerrit Patches:

mediawiki/extensions/Graph : master	Handle missing parser in onParserAfterParse
mediawiki/extensions/Graph : wmf/1.26wmf18	Handle missing parser in onParserAfterParse

Related Objects

Mentioned In: T108976: Call to getIsPreview() on a non-object in Graph\Singleton
T105598: Hook Cite::checkRefsNoReferences has invalid call signature;
rEGRAbd9410614de4: Handle missing parser in onParserAfterParse
rMWe51ff84bb56c: Updated mediawiki/core Project: mediawiki/extensions/Graph…
rMEXTa924c0623dc9: Updated mediawiki/extensions Project: mediawiki/extensions/Graph…
rEGRA10145420ee8a: Handle missing parser in onParserAfterParse

Event Timeline

aude created this task.Aug 12 2015, 1:10 PM

aude raised the priority of this task from to Needs Triage.

aude updated the task description. (Show Details)

aude added projects: MediaWiki-extensions-Graph, Math.

aude added a subscriber: aude.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2015, 1:10 PM

Change 229391 had a related patch set uploaded (by Yurik):
Handle missing parser in onParserAfterParse

https://gerrit.wikimedia.org/r/229391

Change 229391 merged by jenkins-bot:
Handle missing parser in onParserAfterParse

https://gerrit.wikimedia.org/r/229391

Yurik mentioned this in rEGRA10145420ee8a: Handle missing parser in onParserAfterParse.Aug 13 2015, 1:40 AM

Yurik mentioned this in rMEXTa924c0623dc9: Updated mediawiki/extensions Project: mediawiki/extensions/Graph….

Yurik updated the task description. (Show Details)Aug 13 2015, 1:41 AM

Yurik set Security to None.

Yurik updated the task description. (Show Details)

Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 13 2015, 2:00 AM

aude triaged this task as High priority.Aug 13 2015, 1:15 PM

Change 231339 had a related patch set uploaded (by Chad):
Handle missing parser in onParserAfterParse

https://gerrit.wikimedia.org/r/231339

Change 231339 merged by jenkins-bot:
Handle missing parser in onParserAfterParse

https://gerrit.wikimedia.org/r/231339

Yurik mentioned this in rMWe51ff84bb56c: Updated mediawiki/core Project: mediawiki/extensions/Graph….Aug 13 2015, 7:00 PM

demon mentioned this in rEGRAbd9410614de4: Handle missing parser in onParserAfterParse.Aug 13 2015, 7:01 PM

Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 13 2015, 8:00 PM

Reedy merged a task: T109055: Call to a member function getIsPreview() on a non-object (NULL).Aug 14 2015, 11:25 AM

Reedy added a project: Wikimedia-production-error.

Reedy added a subscriber: Reedy.

This still looks to be happening...

Reedy moved this task from Untriaged to Dec 2019 / 1.35.wmf.10+ on the Wikimedia-production-error board.Aug 14 2015, 12:30 PM

Reedy moved this task from Dec 2019 / 1.35.wmf.10+ to Jan 2019 / 1.33.wmf13–14 on the Wikimedia-production-error board.

Yup, seems to be the most prevalent error atm. 846 in the last hour

In T108819#1533761, @gerritbot wrote:

Change 229391 merged by jenkins-bot:
Handle missing parser in onParserAfterParse
https://gerrit.wikimedia.org/r/229391

It's not a missing parser, it's getOptions() returning null, not $parser being null

But the Math extension is to blame anyway, just creating a new Parser, which should then probably be calling startExternalParse passing ParserOptions

https://github.com/wikimedia/mediawiki-extensions-Math/blob/master/MathTexvc.php#L392-L398

@Physikerwelt Can you look at the Math code?

That's definitely one of the worst parts of the Math extension. The hook is
called to ensure that the png image has really been saved to the
filesystem. That this triggers other extensions is not really desired.
Is there another way to only save the image?

demon moved this task from Jan 2019 / 1.33.wmf13–14 to Dec 2019 / 1.35.wmf.10+ on the Wikimedia-production-error board.Sep 2 2015, 5:17 PM

Jdforrester-WMF moved this task from Incoming to Next-up on the Math board.Sep 2 2015, 5:39 PM

BadMethodCallException from line 29 of Graph/Graph.body.php: Call to a member function getIsPreview() on a non-object (NULL) Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

BadMethodCallException from line 29 of Graph/Graph.body.php: Call to a member function getIsPreview() on a non-object (NULL)
Closed, ResolvedPublic
Actions