Page MenuHomePhabricator

Move CentralNotice stuff out of cookies
Open, HighPublic

Description

@ori mentioned that we should try to cut down on our cookie habit, and put stuff in localstorage instead. Apparently the ResourceLoader issue was fixed, that was filling the storage.

Cookies are expensive because they're sent back and forth on every pageview.

Event Timeline

awight created this task.Aug 12 2015, 6:06 PM
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added subscribers: awight, ori.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2015, 6:06 PM
ori awarded a token.Aug 12 2015, 6:51 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 19 2015, 8:49 AM

There is some progress! Unfortunately there are two big areas still to work on for this: bucket cookies and hide cookies. While we do have a viable LocalStorage-based replacement mechanism in place, we also need to check what sort of fallback mechanism, if any, would be needed, at least for Fundraising.

WMDE-leszek set Security to None.Jan 8 2016, 9:42 AM
WMDE-leszek added a subscriber: WMDE-leszek.
ori triaged this task as High priority.Feb 22 2016, 9:12 AM

There is some progress! Unfortunately there are two big areas still to work on for this: bucket cookies and hide cookies. While we do have a viable LocalStorage-based replacement mechanism in place, we also need to check what sort of fallback mechanism, if any, would be needed, at least for Fundraising.

@AndyRussG, what is the status of this work? I just checked and on enwiki I currently have eight(!) cookies from CentralNotice:

  1. CN
  2. HarassmentSurvey_A
  3. HarassmentSurvey_A-wait
  4. bannercount_fundraiser_Dec2015
  5. bannercount_fundraiser_Dec2015-wait
  6. centralnotice-frbanner-seen-fullscreen
  7. centralnotice_bannercount_fr15
  8. centralnotice_bannercount_fr15-wait

@ori thx for the ping! It's not currently programmed for the near future, but I think we should be able to bring it in. I'll talk to folks and get back to you. :)

ori added a comment.Mar 18 2016, 2:52 AM

@ori thx for the ping! It's not currently programmed for the near future, but I think we should be able to bring it in. I'll talk to folks and get back to you. :)

Thanks! Let me know if I can help.

DStrine updated the task description. (Show Details)Mar 29 2016, 7:11 PM
DStrine set the point value for this task to 4.

I'd love to what proportion of our visitors have LocalStorage-capable browsers. Falling back to cookies for the ones that don't support LS seems problematic because these are probably older systems to begin with. Are we considering a non-cookie fallback?

atgo removed a subscriber: atgo.Mar 30 2016, 8:56 PM
Ejegg added a subscriber: Ejegg.Mar 30 2016, 8:57 PM

Are we logging local storage failures now? Browser support is looking pretty good on caniuse, but I dunno how many people disable it via some method. http://caniuse.com/#feat=namevalue-storage. Total Opera mobile looks like less than 1% of our views on https://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm

AndyRussG removed the point value for this task.Apr 13 2016, 10:05 PM

Removed story points because this is now a tracking task (See blocked-by for subtasks.)

mmodell removed a subscriber: awight.Jun 22 2017, 9:39 PM