[Bug] follow up on breaking changes in Wikibase for other extensions
Closed, ResolvedPublic1 Story Points

Description

https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension-zend/512/console
10:05:05 ..........................SSSSSS............................. 5734 / 8818 ( 65%)
10:05:16 ...........................................................PHP Fatal error: Call to undefined method Mock_EntityLookup_ff4f7276::getEntity() in /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/PropertySuggester/src/PropertySuggester/SuggestionGenerator.php on line 59
10:05:16 PHP Stack trace:
10:05:16 PHP 1. {main}() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/phpunit.php:0
10:05:16 PHP 2. PHPUnit_TextUI_Command::main() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/phpunit.php:250
10:05:16 PHP 3. PHPUnit_TextUI_Command->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
10:05:16 PHP 4. PHPUnit_TextUI_TestRunner->doRun() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:176
10:05:16 PHP 5. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/TestRunner.php:350
10:05:16 PHP 6. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
10:05:16 PHP 7. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
10:05:16 PHP 8. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
10:05:16 PHP 9. PHPUnit_Framework_TestSuite->runTest() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:749
10:05:16 PHP 10. MediaWikiTestCase->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:779
10:05:16 PHP 11. PHPUnit_Framework_TestCase->run() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:131
10:05:16 PHP 12. PHPUnit_Framework_TestResult->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:783
10:05:16 PHP 13. PHPUnit_Framework_TestCase->runBare() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestResult.php:648
10:05:16 PHP 14. PHPUnit_Framework_TestCase->runTest() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:838
10:05:16 PHP 15. ReflectionMethod->invokeArgs() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:988
10:05:16 PHP 16. PropertySuggester\SuggestionGeneratorTest->testGenerateSuggestionsWithItem() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php:0
10:05:16 PHP 17. PropertySuggester\SuggestionGenerator->generateSuggestionsByItem() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php:154
10:05:16
10:05:16 Fatal error: Call to undefined method Mock_EntityLookup_ff4f7276::getEntity() in /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/PropertySuggester/src/PropertySuggester/SuggestionGenerator.php on line 59
10:05:16
10:05:16 Call Stack:
10:05:16 0.0007 741480 1. {main}() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/phpunit.php:0
10:05:16 0.1151 21618152 2. PHPUnit_TextUI_Command::main() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/phpunit.php:250
10:05:16 0.1151 21619168 3. PHPUnit_TextUI_Command->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
10:05:16 19.2027 378683392 4. PHPUnit_TextUI_TestRunner->doRun() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:176
10:05:16 19.2077 379412072 5. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/TestRunner.php:350
10:05:16 19.5164 378119432 6. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
10:05:16 27.0250 385237912 7. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
10:05:16 254.4240 809360216 8. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
10:05:16 254.4532 809508632 9. PHPUnit_Framework_TestSuite->runTest() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:749
10:05:16 254.4532 809508632 10. MediaWikiTestCase->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:779
10:05:16 254.4533 809508688 11. PHPUnit_Framework_TestCase->run() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:131
10:05:16 254.4535 809508688 12. PHPUnit_Framework_TestResult->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:783
10:05:16 254.4539 809510824 13. PHPUnit_Framework_TestCase->runBare() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestResult.php:648
10:05:16 254.4546 809556344 14. PHPUnit_Framework_TestCase->runTest() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:838
10:05:16 254.4546 809558528 15. ReflectionMethod->invokeArgs() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:988
10:05:16 254.4546 809558584 16. PropertySuggester\SuggestionGeneratorTest->testGenerateSuggestionsWithItem() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php:0
10:05:16 254.4555 809587088 17. PropertySuggester\SuggestionGenerator->generateSuggestionsByItem() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php:154

JanZerebecki updated the task description. (Show Details)
JanZerebecki raised the priority of this task from to Needs Triage.
JanZerebecki added subscribers: JanZerebecki, Addshore.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2015, 12:14 PM
aude renamed this task from PropertySuggester makes test for build fail to [Bug] PropertySuggester makes test for build fail.Aug 13 2015, 12:44 PM
aude triaged this task as High priority.
aude assigned this task to Addshore.
aude set Security to None.
aude edited a custom field.

Change 231263 had a related patch set uploaded (by Aude):
Use PropertySuggester ~2.4.0

https://gerrit.wikimedia.org/r/231263

Change 231263 abandoned by Aude:
Use PropertySuggester ~2.4.0

Reason:
gah, horribly confused

https://gerrit.wikimedia.org/r/231263

Same problem in quality:
https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension-zend/518/console
13:03:58 ..............................................PHP Fatal error: Interface 'Wikibase\Lib\Store\EntityLookup' not found in /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Quality/tests/phpunit/Helper/JsonFileEntityLookup.php on line 14
13:03:58 PHP Stack trace:
13:03:58 PHP 1. {main}() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/phpunit.php:0
13:03:58 PHP 2. PHPUnit_TextUI_Command::main() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/phpunit.php:250
13:03:58 PHP 3. PHPUnit_TextUI_Command->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
13:03:58 PHP 4. PHPUnit_TextUI_TestRunner->doRun() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:176
13:03:58 PHP 5. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/TestRunner.php:350
13:03:58 PHP 6. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
13:03:58 PHP 7. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
13:03:58 PHP 8. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
13:03:58 PHP 9. PHPUnit_Framework_TestSuite->runTest() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:749
13:03:58 PHP 10. MediaWikiTestCase->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:779
13:03:58 PHP 11. PHPUnit_Framework_TestCase->run() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:131
13:03:58 PHP 12. PHPUnit_Framework_TestResult->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:783
13:03:58 PHP 13. PHPUnit_Framework_TestCase->runBare() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestResult.php:648
13:03:58 PHP 14. WikibaseQuality\ConstraintReport\Test\ConnectionChecker\ConflictsWithCheckerTest->setUp() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:835
13:03:58 PHP 15. Composer\Autoload\ClassLoader->loadClass() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/vendor/composer/ClassLoader.php:0
13:03:58 PHP 16. Composer\Autoload\includeFile() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/vendor/composer/ClassLoader.php:301
13:03:58 PHP 17. include() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/vendor/composer/ClassLoader.php:412
13:03:58
13:03:58 Fatal error: Interface 'Wikibase\Lib\Store\EntityLookup' not found in /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Quality/tests/phpunit/Helper/JsonFileEntityLookup.php on line 14
13:03:58
13:03:58 Call Stack:
13:03:58 0.0024 741480 1. {main}() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/phpunit.php:0
13:03:58 0.1308 21623192 2. PHPUnit_TextUI_Command::main() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/phpunit.php:250
13:03:58 0.1308 21624208 3. PHPUnit_TextUI_Command->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
13:03:58 14.5975 378682344 4. PHPUnit_TextUI_TestRunner->doRun() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:176
13:03:58 14.6012 379411448 5. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/TextUI/TestRunner.php:350
13:03:58 14.8961 378119240 6. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
13:03:58 18.7641 385235504 7. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
13:03:58 216.4638 808960696 8. PHPUnit_Framework_TestSuite->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:709
13:03:58 216.4646 808962168 9. PHPUnit_Framework_TestSuite->runTest() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:749
13:03:58 216.4646 808962168 10. MediaWikiTestCase->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:779
13:03:58 216.4647 808962192 11. PHPUnit_Framework_TestCase->run() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:131
13:03:58 216.4648 808962192 12. PHPUnit_Framework_TestResult->run() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:783
13:03:58 216.4651 808964368 13. PHPUnit_Framework_TestCase->runBare() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestResult.php:648
13:03:58 216.4652 809005888 14. WikibaseQuality\ConstraintReport\Test\ConnectionChecker\ConflictsWithCheckerTest->setUp() /srv/deployment/integration/phpunit/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php:835
13:03:58 216.4654 809007488 15. Composer\Autoload\ClassLoader->loadClass() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/vendor/composer/ClassLoader.php:0
13:03:58 216.4654 809007488 16. Composer\Autoload\includeFile() /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/vendor/composer/ClassLoader.php:301
13:03:58 216.4703 809040448 17. include('/mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Quality/tests/phpunit/Helper/JsonFileEntityLookup.php') /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/vendor/composer/ClassLoader.php:412

Change 231275 had a related patch set uploaded (by JanZerebecki):
Use EntityLookup from DataModelServices

https://gerrit.wikimedia.org/r/231275

JanZerebecki renamed this task from [Bug] PropertySuggester makes test for build fail to [Bug] move of EntityLookup to services lib broke extensions.Aug 13 2015, 2:20 PM
JanZerebecki renamed this task from [Bug] move of EntityLookup to services lib broke extensions to [Bug] follow up on breaking changes in Wikibase for other extensions.Aug 13 2015, 2:50 PM

Change 231275 merged by jenkins-bot:
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231275

Change 231509 had a related patch set uploaded (by Addshore):
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231509

Change 231504 had a related patch set uploaded (by Addshore):
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231504

Change 231504 merged by jenkins-bot:
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231504

Change 231517 had a related patch set uploaded (by Addshore):
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231517

Change 231520 had a related patch set uploaded (by Addshore):
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231520

Change 231517 merged by jenkins-bot:
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231517

Change 231520 merged by jenkins-bot:
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231520

https://gerrit.wikimedia.org/r/#/c/231509/ is the last remaining patch to be merged

Change 231509 merged by Thiemo Mättig (WMDE):
Follow up on compatibility breaks in Wikibase

https://gerrit.wikimedia.org/r/231509

Addshore closed this task as Resolved.

All merged