Page MenuHomePhabricator
Create Task
Maniphest T108959

Deprecated: Elastica\Query::setFilter() is deprecated.
Closed, ResolvedPublic
Actions

Description

This is showing up in production, from fatalmonitor:

Deprecated: Elastica\Query::setFilter() is deprecated. Use Elastica\Query::setPostFilter() instead. in /srv/mediawiki/php-1.26wmf18/vendor/ruflin/elastica/lib/Elastica/Query.php on line 144

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Live hack to generate backtrace in Elastica\Querymediawiki/vendorwmf/1.26wmf18+1 -1
Elastica\Query::setFilter() is deprecated.mediawiki/extensions/Flowwmf/1.26wmf18+1 -1
Elastica\Query::setFilter() is deprecated.mediawiki/extensions/GeoDatawmf/1.26wmf18+2 -2
Elastica\Query::setFilter() is deprecated.mediawiki/extensions/GeoDatamaster+2 -2
Elastica\Query::setFilter() is deprecated.mediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• mmodell created this task.Aug 13 2015, 4:15 PM
• mmodell raised the priority of this task from to Needs Triage.
• mmodell updated the task description. (Show Details)
• mmodell added projects: Wikimedia-production-error, CirrusSearch.
• mmodell subscribed.
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptAug 13 2015, 4:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• demon triaged this task as Medium priority.Aug 13 2015, 6:24 PM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.
• demon subscribed.
Reedy merged a task: T109053: Deprecated: Deprecated: Elastica\Query::setFilter() is deprecated.Aug 14 2015, 11:36 AM
Reedy added subscribers: gerritbot, Reedy.
In T109053#1539156, @gerritbot wrote:

Change 231528 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated

https://gerrit.wikimedia.org/r/231528

Fixes one in the maintenance script

I wonder if it's worth hacking in so we get a stack trace...

gerritbot added a comment.Aug 14 2015, 11:45 AM

Change 231539 had a related patch set uploaded (by Reedy):
Live hack to generate backtrace in Elastica\Query

https://gerrit.wikimedia.org/r/231539

gerritbot added a project: Patch-For-Review.Aug 14 2015, 11:45 AM
Nikerabbit subscribed.Aug 14 2015, 11:47 AM

Oh please review https://gerrit.wikimedia.org/r/#/c/230363/

Reedy mentioned this in rETRA752bf808f13a: Elastica\Query::setFilter() is deprecated. Use setPostFilter() instead.Aug 14 2015, 11:51 AM
Nikerabbit mentioned this in rMEXT6a6672261fa4: Updated mediawiki/extensions Project: mediawiki/extensions/Translate….Aug 14 2015, 11:51 AM
Nikerabbit mentioned this in rMW23f986732820: Updated mediawiki/core Project: mediawiki/extensions/Translate….Aug 14 2015, 11:54 AM
Reedy mentioned this in rETRA2087afdca64c: Elastica\Query::setFilter() is deprecated. Use setPostFilter() instead.Aug 14 2015, 11:55 AM
• Forrestbot added projects: WMF-deploy-2015-08-18_(1.26wmf19), WMF-deploy-2015-08-11_(1.26wmf18).Aug 14 2015, 12:00 PM
gerritbot added a comment.Aug 14 2015, 12:08 PM

Change 231543 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231543

gerritbot added a comment.Aug 14 2015, 12:11 PM

Change 231544 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231544

Reedy added a comment.Aug 14 2015, 12:13 PM
reedy@tin:/srv/mediawiki-staging/php-1.26wmf18$ grep -R setFilter\( *
extensions/Flow/includes/Search/SearchEngine.php:			$query->setFilter( $filter );
extensions/CirrusSearch/maintenance/updateVersionIndex.php:			$query->setFilter( $filter );
extensions/Translate/ttmserver/ElasticSearchTTMServer.php:		$boostQuery->setFilter( $fuzzyFilter );
extensions/Translate/ttmserver/ElasticSearchTTMServer.php:		$filteredQuery->setFilter( $languageFilter );
extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				->setFilter( $filter );
extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				$query->setFilter( $outerFilter );
extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				$query->setFilter( $nested );
extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js:				setFilter( 'status', 'draft' );
extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js:				setFilter( 'status', 'published' );
extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js:			setFilter( 'sourceLanguage', code );
extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js:			setFilter( 'targetLanguage', code );
extensions/CodeEditor/modules/ace/ext-language_tools.js:            this.completions.setFilter(prefix);
extensions/CodeEditor/modules/ace/ext-language_tools.js:            this.completions.setFilter(prefix);
extensions/SemanticResultFormats/resources/jquery.jqgrid/jquery.jqGrid.4.4.0min.js:b[c.sValue]=b[c.sOper]="":b[c.sFilter]="";d[0].resetFilter();j&&a(".ui-template",p).val("default");a.extend(e.p.postData,b);a(e).triggerHandler("jqGridFilterReset");a.isFunction(c.onReset)&&c.onReset.call(e);a(e).trigger("reloadGrid",[{page:1}]);return false});d(a("#"+l));a(".fm-button:not(.ui-state-disabled)",p).hover(function(){a(this).addClass("ui-state-hover")},function(){a(this).removeClass("ui-state-hover")})}}})},editGridRow:function(u,d){d=a.extend({top:0,left:0,width:300,height:"auto",dataheight:"auto",
extensions/SemanticResultFormats/resources/jquery.jqgrid/jquery.jqGrid.4.4.0min.js:this.toUserFriendlyString()});return a},filterData:function(){var a;this.each(function(){a=this.p.filter});return a},getParameter:function(a){return void 0!==a&&this.p.hasOwnProperty(a)?this.p[a]:this.p},resetFilter:function(){return this.each(function(){this.resetFilter()})},addFilter:function(a){"string"===typeof a&&(a=jQuery.jgrid.parse(a));this.each(function(){this.p.filter=a;this.reDraw();this.onchange()})}})})(jQuery);
setFilter:extensions/Flow/includes/Search/SearchEngine.php:			$query->setFilter( $filter );
setFilter:extensions/CirrusSearch/maintenance/updateVersionIndex.php:			$query->setFilter( $filter );
setFilter:extensions/Translate/ttmserver/ElasticSearchTTMServer.php:		$boostQuery->setFilter( $fuzzyFilter );
setFilter:extensions/Translate/ttmserver/ElasticSearchTTMServer.php:		$filteredQuery->setFilter( $languageFilter );
setFilter:extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				->setFilter( $filter );
setFilter:extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				$query->setFilter( $outerFilter );
setFilter:extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				$query->setFilter( $nested );
setFilter:extensions/SemanticResultFormats/resources/jquery.jqgrid/jquery.jqGrid.4.4.0min.js:b[c.sValue]=b[c.sOper]="":b[c.sFilter]="";d[0].resetFilter();j&&a(".ui-template",p).val("default");a.extend(e.p.postData,b);a(e).triggerHandler("jqGridFilterReset");a.isFunction(c.onReset)&&c.onReset.call(e);a(e).trigger("reloadGrid",[{page:1}]);return false});d(a("#"+l));a(".fm-button:not(.ui-state-disabled)",p).hover(function(){a(this).addClass("ui-state-hover")},function(){a(this).removeClass("ui-state-hover")})}}})},editGridRow:function(u,d){d=a.extend({top:0,left:0,width:300,height:"auto",dataheight:"auto",
vendor/ruflin/elastica/CHANGELOG.md:- Deprecated: Elastica\Query::setFilter() is deprecated. Use Elastica\Query::setPostFilter() instead. [#669](https://github.com/ruflin/Elastica/issues/669/)
vendor/ruflin/elastica/lib/Elastica/Filter/BoolNot.php:        $this->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Filter/BoolNot.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Filter/Nested.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Filter/HasChild.php:            $this->setFilter($query);
vendor/ruflin/elastica/lib/Elastica/Filter/HasChild.php:    public function setFilter($filter)
vendor/ruflin/elastica/lib/Elastica/Filter/Indices.php:        $this->setIndices($indices)->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Filter/Indices.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Filter/HasParent.php:            $this->setFilter($query);
vendor/ruflin/elastica/lib/Elastica/Filter/HasParent.php:    public function setFilter($filter)
vendor/ruflin/elastica/lib/Elastica/Query/Filtered.php:        $this->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Query/Filtered.php:    public function setFilter(AbstractFilter $filter = null)
vendor/ruflin/elastica/lib/Elastica/Query/ConstantScore.php:            $this->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Query/ConstantScore.php:    public function setFilter($filter)
vendor/ruflin/elastica/lib/Elastica/Query/FunctionScore.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Query.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Query.php:        trigger_error('Deprecated: Elastica\Query::setFilter() is deprecated. Use Elastica\Query::setPostFilter() instead.', E_USER_DEPRECATED);
vendor/ruflin/elastica/lib/Elastica/Aggregation/Filter.php:            $this->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Aggregation/Filter.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Facet/Filter.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Facet/AbstractFacet.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/test/lib/Elastica/Test/Filter/NestedFilterWithSetFilterTest.php:        $filter->setFilter($query);
vendor/ruflin/elastica/test/lib/Elastica/Test/Filter/NestedFilterWithSetFilterTest.php:        $filter->setFilter($query);
vendor/ruflin/elastica/test/lib/Elastica/Test/Filter/NestedFilterWithSetFilterTest.php:        $filter->setFilter($query);
vendor/ruflin/elastica/test/lib/Elastica/Test/Query/ConstantScoreTest.php:        $query->setFilter($filter);
vendor/ruflin/elastica/test/lib/Elastica/Test/Query/ConstantScoreTest.php:        $query->setFilter($filter);
vendor/ruflin/elastica/test/lib/Elastica/Test/Aggregation/FilterTest.php:        $agg->setFilter(new Range('stock', array('gt' => 0)));
vendor/ruflin/elastica/test/lib/Elastica/Test/Aggregation/FilterTest.php:        $agg->setFilter(new Term(array('color' => 'blue')));
vendor/ruflin/elastica/test/lib/Elastica/Test/Facet/FilterTest.php:        $facet->setFilter($filter);
gerritbot added a comment.Aug 14 2015, 1:00 PM

Change 231543 merged by jenkins-bot:
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231543

gerritbot added a comment.Aug 14 2015, 1:00 PM

Change 231544 merged by jenkins-bot:
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231544

Reedy mentioned this in rMEXTc9f2815f8ebb: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Aug 14 2015, 1:00 PM
Reedy mentioned this in rMEXT089b74873f3c: Updated mediawiki/extensions Project: mediawiki/extensions/GeoData….
gerritbot added a comment.Aug 14 2015, 1:01 PM

Change 231551 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231551

gerritbot added a comment.Aug 14 2015, 1:01 PM

Change 231552 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231552

Reedy mentioned this in rEFLW2c3d57cf5fea: Elastica\Query::setFilter() is deprecated..Aug 14 2015, 1:01 PM
Reedy mentioned this in rEGDA2f68f1b7e069: Elastica\Query::setFilter() is deprecated..Aug 14 2015, 1:04 PM
gerritbot added a comment.Aug 14 2015, 1:04 PM

Change 231551 merged by jenkins-bot:
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231551

gerritbot added a comment.Aug 14 2015, 1:04 PM

Change 231552 merged by jenkins-bot:
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231552

Reedy mentioned this in rEGDAbb96fd367e60: Elastica\Query::setFilter() is deprecated..Aug 14 2015, 1:04 PM
Reedy mentioned this in rMW52dc6e89f130: Updated mediawiki/core Project: mediawiki/extensions/Flow….
Reedy mentioned this in rMW0d424a034179: Updated mediawiki/core Project: mediawiki/extensions/GeoData….
Reedy mentioned this in rEFLWaf4eafdb51a6: Elastica\Query::setFilter() is deprecated..
Reedy closed this task as Resolved.Aug 14 2015, 1:15 PM
Reedy claimed this task.

Look to have all gone away now...

gerritbot added a comment.Aug 23 2015, 11:42 AM

Change 231539 abandoned by Reedy:
Live hack to generate backtrace in Elastica\Query

https://gerrit.wikimedia.org/r/231539

• demon moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.Aug 24 2015, 3:23 AM
Nikerabbit mentioned this in T76727: Figure out how to upgrade to elastica 1.3.4.0 in Translate.Oct 1 2015, 7:34 AM
• Deskana moved this task from Inbox to Resolved/Invalid/Declined/Legacy on the CirrusSearch board.Dec 31 2015, 5:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits