Page MenuHomePhabricator

Deprecated: Elastica\Query::setFilter() is deprecated.
Closed, ResolvedPublic

Description

This is showing up in production, from fatalmonitor:

Deprecated: Elastica\Query::setFilter() is deprecated. Use Elastica\Query::setPostFilter() instead. in /srv/mediawiki/php-1.26wmf18/vendor/ruflin/elastica/lib/Elastica/Query.php on line 144

Details

Related Gerrit Patches:
mediawiki/vendor : wmf/1.26wmf18Live hack to generate backtrace in Elastica\Query
mediawiki/extensions/Flow : wmf/1.26wmf18Elastica\Query::setFilter() is deprecated.
mediawiki/extensions/GeoData : wmf/1.26wmf18Elastica\Query::setFilter() is deprecated.
mediawiki/extensions/GeoData : masterElastica\Query::setFilter() is deprecated.
mediawiki/extensions/Flow : masterElastica\Query::setFilter() is deprecated.

Event Timeline

mmodell created this task.Aug 13 2015, 4:15 PM
mmodell raised the priority of this task from to Needs Triage.
mmodell updated the task description. (Show Details)
mmodell added a subscriber: mmodell.
Restricted Application added a project: Discovery. · View Herald TranscriptAug 13 2015, 4:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
demon triaged this task as Medium priority.Aug 13 2015, 6:24 PM
demon added a subscriber: demon.
Reedy added subscribers: gerritbot, Reedy.

Change 231528 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated
https://gerrit.wikimedia.org/r/231528

Fixes one in the maintenance script

I wonder if it's worth hacking in so we get a stack trace...

Change 231539 had a related patch set uploaded (by Reedy):
Live hack to generate backtrace in Elastica\Query

https://gerrit.wikimedia.org/r/231539

Change 231543 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231543

Change 231544 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231544

reedy@tin:/srv/mediawiki-staging/php-1.26wmf18$ grep -R setFilter\( *
extensions/Flow/includes/Search/SearchEngine.php:			$query->setFilter( $filter );
extensions/CirrusSearch/maintenance/updateVersionIndex.php:			$query->setFilter( $filter );
extensions/Translate/ttmserver/ElasticSearchTTMServer.php:		$boostQuery->setFilter( $fuzzyFilter );
extensions/Translate/ttmserver/ElasticSearchTTMServer.php:		$filteredQuery->setFilter( $languageFilter );
extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				->setFilter( $filter );
extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				$query->setFilter( $outerFilter );
extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				$query->setFilter( $nested );
extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js:				setFilter( 'status', 'draft' );
extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js:				setFilter( 'status', 'published' );
extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js:			setFilter( 'sourceLanguage', code );
extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js:			setFilter( 'targetLanguage', code );
extensions/CodeEditor/modules/ace/ext-language_tools.js:            this.completions.setFilter(prefix);
extensions/CodeEditor/modules/ace/ext-language_tools.js:            this.completions.setFilter(prefix);
extensions/SemanticResultFormats/resources/jquery.jqgrid/jquery.jqGrid.4.4.0min.js:b[c.sValue]=b[c.sOper]="":b[c.sFilter]="";d[0].resetFilter();j&&a(".ui-template",p).val("default");a.extend(e.p.postData,b);a(e).triggerHandler("jqGridFilterReset");a.isFunction(c.onReset)&&c.onReset.call(e);a(e).trigger("reloadGrid",[{page:1}]);return false});d(a("#"+l));a(".fm-button:not(.ui-state-disabled)",p).hover(function(){a(this).addClass("ui-state-hover")},function(){a(this).removeClass("ui-state-hover")})}}})},editGridRow:function(u,d){d=a.extend({top:0,left:0,width:300,height:"auto",dataheight:"auto",
extensions/SemanticResultFormats/resources/jquery.jqgrid/jquery.jqGrid.4.4.0min.js:this.toUserFriendlyString()});return a},filterData:function(){var a;this.each(function(){a=this.p.filter});return a},getParameter:function(a){return void 0!==a&&this.p.hasOwnProperty(a)?this.p[a]:this.p},resetFilter:function(){return this.each(function(){this.resetFilter()})},addFilter:function(a){"string"===typeof a&&(a=jQuery.jgrid.parse(a));this.each(function(){this.p.filter=a;this.reDraw();this.onchange()})}})})(jQuery);
setFilter:extensions/Flow/includes/Search/SearchEngine.php:			$query->setFilter( $filter );
setFilter:extensions/CirrusSearch/maintenance/updateVersionIndex.php:			$query->setFilter( $filter );
setFilter:extensions/Translate/ttmserver/ElasticSearchTTMServer.php:		$boostQuery->setFilter( $fuzzyFilter );
setFilter:extensions/Translate/ttmserver/ElasticSearchTTMServer.php:		$filteredQuery->setFilter( $languageFilter );
setFilter:extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				->setFilter( $filter );
setFilter:extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				$query->setFilter( $outerFilter );
setFilter:extensions/GeoData/api/ApiQueryGeoSearchElastic.php:				$query->setFilter( $nested );
setFilter:extensions/SemanticResultFormats/resources/jquery.jqgrid/jquery.jqGrid.4.4.0min.js:b[c.sValue]=b[c.sOper]="":b[c.sFilter]="";d[0].resetFilter();j&&a(".ui-template",p).val("default");a.extend(e.p.postData,b);a(e).triggerHandler("jqGridFilterReset");a.isFunction(c.onReset)&&c.onReset.call(e);a(e).trigger("reloadGrid",[{page:1}]);return false});d(a("#"+l));a(".fm-button:not(.ui-state-disabled)",p).hover(function(){a(this).addClass("ui-state-hover")},function(){a(this).removeClass("ui-state-hover")})}}})},editGridRow:function(u,d){d=a.extend({top:0,left:0,width:300,height:"auto",dataheight:"auto",
vendor/ruflin/elastica/CHANGELOG.md:- Deprecated: Elastica\Query::setFilter() is deprecated. Use Elastica\Query::setPostFilter() instead. [#669](https://github.com/ruflin/Elastica/issues/669/)
vendor/ruflin/elastica/lib/Elastica/Filter/BoolNot.php:        $this->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Filter/BoolNot.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Filter/Nested.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Filter/HasChild.php:            $this->setFilter($query);
vendor/ruflin/elastica/lib/Elastica/Filter/HasChild.php:    public function setFilter($filter)
vendor/ruflin/elastica/lib/Elastica/Filter/Indices.php:        $this->setIndices($indices)->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Filter/Indices.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Filter/HasParent.php:            $this->setFilter($query);
vendor/ruflin/elastica/lib/Elastica/Filter/HasParent.php:    public function setFilter($filter)
vendor/ruflin/elastica/lib/Elastica/Query/Filtered.php:        $this->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Query/Filtered.php:    public function setFilter(AbstractFilter $filter = null)
vendor/ruflin/elastica/lib/Elastica/Query/ConstantScore.php:            $this->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Query/ConstantScore.php:    public function setFilter($filter)
vendor/ruflin/elastica/lib/Elastica/Query/FunctionScore.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Query.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Query.php:        trigger_error('Deprecated: Elastica\Query::setFilter() is deprecated. Use Elastica\Query::setPostFilter() instead.', E_USER_DEPRECATED);
vendor/ruflin/elastica/lib/Elastica/Aggregation/Filter.php:            $this->setFilter($filter);
vendor/ruflin/elastica/lib/Elastica/Aggregation/Filter.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Facet/Filter.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/lib/Elastica/Facet/AbstractFacet.php:    public function setFilter(AbstractFilter $filter)
vendor/ruflin/elastica/test/lib/Elastica/Test/Filter/NestedFilterWithSetFilterTest.php:        $filter->setFilter($query);
vendor/ruflin/elastica/test/lib/Elastica/Test/Filter/NestedFilterWithSetFilterTest.php:        $filter->setFilter($query);
vendor/ruflin/elastica/test/lib/Elastica/Test/Filter/NestedFilterWithSetFilterTest.php:        $filter->setFilter($query);
vendor/ruflin/elastica/test/lib/Elastica/Test/Query/ConstantScoreTest.php:        $query->setFilter($filter);
vendor/ruflin/elastica/test/lib/Elastica/Test/Query/ConstantScoreTest.php:        $query->setFilter($filter);
vendor/ruflin/elastica/test/lib/Elastica/Test/Aggregation/FilterTest.php:        $agg->setFilter(new Range('stock', array('gt' => 0)));
vendor/ruflin/elastica/test/lib/Elastica/Test/Aggregation/FilterTest.php:        $agg->setFilter(new Term(array('color' => 'blue')));
vendor/ruflin/elastica/test/lib/Elastica/Test/Facet/FilterTest.php:        $facet->setFilter($filter);

Change 231543 merged by jenkins-bot:
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231543

Change 231544 merged by jenkins-bot:
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231544

Change 231551 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231551

Change 231552 had a related patch set uploaded (by Reedy):
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231552

Change 231551 merged by jenkins-bot:
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231551

Change 231552 merged by jenkins-bot:
Elastica\Query::setFilter() is deprecated.

https://gerrit.wikimedia.org/r/231552

Reedy closed this task as Resolved.Aug 14 2015, 1:15 PM
Reedy claimed this task.

Look to have all gone away now...

Change 231539 abandoned by Reedy:
Live hack to generate backtrace in Elastica\Query

https://gerrit.wikimedia.org/r/231539