Page MenuHomePhabricator

[Regression pre-wmf19] Inspectors insta-close on open due to OOUI breakage
Closed, ResolvedPublic8 Estimated Story Points

Event Timeline

Jdforrester-WMF raised the priority of this task from to Unbreak Now!.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF subscribed.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF updated the task description. (Show Details)

Looks like this line:

!OO.ui.contains( widget.$element, document.activeElement, true ) &&

Should be like this:

!OO.ui.contains( widget.$element[0], document.activeElement, true ) &&

No promises that this is the only issue, but VE's inspectors seem to work correctly with that patch.

Hmm, actually, it gets more interesting for LanguageInspector, which can open a dialog. Opening the dialog shouldn't close the inspector, but it does. I think it would be safer to remove the general 'focusout' handler from PopupWidget.

Change 231338 had a related patch set uploaded (by Bartosz Dziewoński):
PopupWidget: Remove 'focusout' handling again, limit to CapsuleMultiSelectWidget

https://gerrit.wikimedia.org/r/231338

Change 231338 merged by jenkins-bot:
PopupWidget: Remove 'focusout' handling again, limit to CapsuleMultiSelectWidget

https://gerrit.wikimedia.org/r/231338