Page MenuHomePhabricator

Gallery shows images for which there are no corresponding thumbnails
Closed, DuplicatePublic

Description

Description

Steps to reproduce

  1. Go to the main article.
  2. Tap the first image.
  3. Flip through the gallery.

Expected results

Only larger versions of the thumbnail images visible on the main page are shown.

Actual results

Larger images for all thumbnail images and some (but not all) images on en.wikipedia.org are shown.

Environments observed

App version: rAPAW6e9dc098afa3
Device model: Phone | Tracfone LG Ultimate 2 (LGL41C) | Android KitKat 4.4.2 (API 19)
Device language: English

This issue may be related to T104096.

Example:

https://en.m.wikipedia.org/w/api.php?action=query&format=json&prop=pageterms%7Cpageimages%7Cpageprops&ppprop=mainpage%7Cdisambiguation&wbptterms=description&generator=search&gsrsearch=morelike%3ASupernature%20(Goldfrapp%20album)&gsrnamespace=0&gsrwhat=text&gsrinfo=&gsrprop=redirecttitle&gsrlimit=5&piprop=thumbnail&pithumbsize=640&pilimit=5&continue=

{
    "batchcomplete": "",
    "continue": {
        "gsroffset": 5,
        "continue": "gsroffset||"
    },
    "query": {
        "pages": {
            "2134961": {
                "pageid": 2134961,
                "ns": 0,
                "title": "Alison Goldfrapp",
                "index": 4,
                "terms": {
                    "description": [
                        "English singer-songwriter"
                    ]
                },
                "thumbnail": {
                    "source": "https://upload.wikimedia.org/wikipedia/commons/d/d9/GoldfrappLive20082.jpg",
                    "width": "534",
                    "height": "600"
                }
            },
            "2772305": {
                "pageid": 2772305,
                "ns": 0,
                "title": "Goldfrapp discography",
                "index": 5,
                "thumbnail": {
                    "source": "https://upload.wikimedia.org/wikipedia/commons/thumb/8/84/GoldfrappCambridge.jpg/640px-GoldfrappCambridge.jpg",
                    "width": 640,
                    "height": 505
                }
            },
            "2795099": {
                "pageid": 2795099,
                "ns": 0,
                "title": "Number 1 (Goldfrapp song)",
                "index": 3,
                "thumbnail": {
                    "source": "https://upload.wikimedia.org/wikipedia/en/f/f9/Goldfrapp_-_Number_1.jpg",
                    "width": "251",
                    "height": "251"
                }
            },
            "2814494": {
                "pageid": 2814494,
                "ns": 0,
                "title": "Ooh La La (Goldfrapp song)",
                "index": 1,
                "terms": {
                    "description": [
                        "Goldfrapp song"
                    ]
                },
                "thumbnail": {
                    "source": "https://upload.wikimedia.org/wikipedia/en/8/8c/Goldfrapp%2C_Ooh_La_La_cover.png",
                    "width": "300",
                    "height": "300"
                }
            },
            "25282935": {
                "pageid": 25282935,
                "ns": 0,
                "title": "Head First (Goldfrapp album)",
                "index": 2,
                "terms": {
                    "description": [
                        "studio album by Goldfrapp"
                    ]
                },
                "thumbnail": {
                    "source": "https://upload.wikimedia.org/wikipedia/en/a/ae/Goldfrapp_-_Head_First.png",
                    "width": "300",
                    "height": "300"
                }
            }
        }
    }
}

https://en.m.wikipedia.org/w/api.php?action=query&format=json&titles=Main%20Page&continue=&prop=imageinfo&iiprop=dimensions%7Cmime&generator=images&redirects=&gimlimit=256

{
    "batchcomplete": "",
    "query": {
        "pages": {
            "3993216": {
                "pageid": 3993216,
                "ns": 6,
                "title": "File:Wikispecies-logo-35px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 3629,
                        "width": 35,
                        "height": 41,
                        "mime": "image/png"
                    }
                ]
            },
            "4504570": {
                "pageid": 4504570,
                "ns": 6,
                "title": "File:Wikibooks-logo-35px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 1722,
                        "width": 35,
                        "height": 35,
                        "mime": "image/png"
                    }
                ]
            },
            "4504601": {
                "pageid": 4504601,
                "ns": 6,
                "title": "File:Wikisource-logo-35px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 2280,
                        "width": 35,
                        "height": 37,
                        "mime": "image/png"
                    }
                ]
            },
            "6532245": {
                "pageid": 6532245,
                "ns": 6,
                "title": "File:Wikinews-logo-51px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 2921,
                        "width": 51,
                        "height": 30,
                        "mime": "image/png"
                    }
                ]
            },
            "6532248": {
                "pageid": 6532248,
                "ns": 6,
                "title": "File:Wikiquote-logo-51px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 1388,
                        "width": 51,
                        "height": 41,
                        "mime": "image/png"
                    }
                ]
            },
            "6532252": {
                "pageid": 6532252,
                "ns": 6,
                "title": "File:Wikiversity-logo-41px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 1227,
                        "width": 41,
                        "height": 32,
                        "mime": "image/png"
                    }
                ]
            },
            "6532256": {
                "pageid": 6532256,
                "ns": 6,
                "title": "File:Commons-logo-31px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 1694,
                        "width": 31,
                        "height": 41,
                        "mime": "image/png"
                    }
                ]
            },
            "20279498": {
                "pageid": 20279498,
                "ns": 6,
                "title": "File:Meta-logo-35px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 1611,
                        "width": 35,
                        "height": 35,
                        "mime": "image/png"
                    }
                ]
            },
            "21642559": {
                "pageid": 21642559,
                "ns": 6,
                "title": "File:Wiktionary-logo-51px.png",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "size": 478,
                        "width": 51,
                        "height": 35,
                        "mime": "image/png"
                    }
                ]
            },
            "43282195": {
                "pageid": 43282195,
                "ns": 6,
                "title": "File:Kalasan Temple from the north-east, 23 November 2013.jpg",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 10201046,
                        "width": 4933,
                        "height": 3120,
                        "mime": "image/jpeg"
                    }
                ]
            },
            "-1": {
                "ns": 6,
                "title": "File:15thPentagonTiling.svg",
                "missing": "",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 85349,
                        "width": 125,
                        "height": 124,
                        "mime": "image/svg+xml"
                    }
                ]
            },
            "-2": {
                "ns": 6,
                "title": "File:Ben Affleck 2009 2.jpg",
                "missing": "",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 1391593,
                        "width": 2000,
                        "height": 3008,
                        "mime": "image/jpeg"
                    }
                ]
            },
            "-3": {
                "ns": 6,
                "title": "File:Bundesarchiv Bild183-S74834, Günther Stempel.jpg",
                "missing": "",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 35767,
                        "width": 539,
                        "height": 800,
                        "mime": "image/jpeg"
                    }
                ]
            },
            "-4": {
                "ns": 6,
                "title": "File:Goldfrapp112 crop.jpg",
                "missing": "",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 50126,
                        "width": 186,
                        "height": 223,
                        "mime": "image/jpeg"
                    }
                ]
            },
            "-5": {
                "ns": 6,
                "title": "File:Indonesia declaration of independence 17 August 1945.jpg",
                "missing": "",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 650879,
                        "width": 1600,
                        "height": 1066,
                        "mime": "image/jpeg"
                    }
                ]
            },
            "-6": {
                "ns": 6,
                "title": "File:Mediawiki-logo.png",
                "missing": "",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 24969,
                        "width": 135,
                        "height": 102,
                        "mime": "image/png"
                    }
                ]
            },
            "-7": {
                "ns": 6,
                "title": "File:Wikidata-logo.svg",
                "missing": "",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 621,
                        "width": 1050,
                        "height": 590,
                        "mime": "image/svg+xml"
                    }
                ]
            },
            "-8": {
                "ns": 6,
                "title": "File:Wikivoyage-Logo-v3-icon.svg",
                "missing": "",
                "imagerepository": "shared",
                "imageinfo": [
                    {
                        "size": 2587,
                        "width": 193,
                        "height": 193,
                        "mime": "image/svg+xml"
                    }
                ]
            }
        }
    }
}

In this case, only the Goldfrapp and Pentagon tiling (missing!) pics were expected.

Event Timeline

Niedzielski raised the priority of this task from to Needs Triage.
Niedzielski updated the task description. (Show Details)
Niedzielski subscribed.

@Niedzielski I would recommend filing this issue against the API (prop=images), since that's the source of the images.

@Niedzielski I would recommend filing this issue against the API (prop=images), since that's the source of the images.

As far as I can tell with the information provided so far, the only "bug" here is that the API returns all the images that are in the page while mobile hides some of them in its rendered output.

If that's the actual issue being reported here, I'd close this as invalid from an API perspective.

@Dbrant, any objections to filtering this on the client side?

@Niedzielski No objections, but really, I think we'll reimagine the whole native "home page" experience sooner than we'll address this particular issue.

@Dbrant, sounds good. Any objection to removing MediaWiki-API?

This seems to effect articles too. The cat article shows a picture of an okapi when leafing through the gallery but none is present in the article.

Niedzielski renamed this task from Gallery on main page show images for which there are no corresponding thumbnails to Galleryshow images for which there are no corresponding thumbnails.Aug 21 2015, 8:21 PM
Niedzielski renamed this task from Galleryshow images for which there are no corresponding thumbnails to Gallery shows images for which there are no corresponding thumbnails.Aug 21 2015, 8:26 PM