Page MenuHomePhabricator
Create Task
Maniphest T108986

Pixelated banners
Closed, ResolvedPublic
Actions

Description

The banner {{PAGEBANNER:"The Split", Caye Caulker, Belize.jpg|toc=yes}} on a 1694px screen looks pixelated. We should add a max-width based on the maximum available resolution.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikidataPageBannermaster+3 -1WikidataPageBanner add max-width
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 13 2015, 7:41 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Wikidata-Page-Banner.
Jdlrobson moved this task to Epics on the Wikidata-Page-Banner board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 13 2015, 7:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Aug 14 2015, 11:17 AM
Sumit added a subscriber: Sumit.Aug 14 2015, 8:46 PM

It would not be possible to determine max-width of image in css. Should a js approach be used after setting a data-max-width attribute in html of banner image?

Jdlrobson added a comment.Aug 15 2015, 12:12 AM

You could add an inline style surely and do this css only?

style="max-width:<max width>px;"

gerritbot added a subscriber: gerritbot.Aug 16 2015, 2:56 PM

Change 231886 had a related patch set uploaded (by Sumit):
WikidataPageBanner add max-wdith

https://gerrit.wikimedia.org/r/231886

gerritbot added a project: Patch-For-Review.Aug 16 2015, 2:56 PM
gerritbot added a comment.Aug 17 2015, 3:55 PM

Change 231886 merged by jenkins-bot:
WikidataPageBanner add max-width

https://gerrit.wikimedia.org/r/231886

Jdlrobson mentioned this in rEWDP419bc0454f9c: WikidataPageBanner add max-width.Aug 17 2015, 3:55 PM
Diffusion mentioned this in rMEXT799266089d09: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataPageBanner….Aug 17 2015, 3:56 PM
Sumit closed this task as Resolved.Aug 17 2015, 5:13 PM
Sumit set Security to None.
Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 19 2015, 6:02 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL