Maniphest T108988

Remove beta header, clean up code
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Experiment is over and results have been posted. Let's remove the beta header and clean up as much as we can.

AC:

The header on beta is exactly the same as in stable.
The code is clean and beautiful and the experiment hasn't left cruft on the codebase.
The removal of the feature is documented on mediawiki.org.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+18 -191	Remove the experimental header from alpha and beta

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		Jhernandez	T108652 In mobile web Beta, sometimes search field is inoperable (especially on slow connections)
		Resolved		bmansurov	T108988 Remove beta header, clean up code
		Resolved		bmansurov	T109904 Regression: In stable last modified bar padding broken

Event Timeline

Jhernandez created this task.Aug 13 2015, 7:54 PM

Jhernandez raised the priority of this task from to High.

Jhernandez updated the task description. (Show Details)

Jhernandez added a project: Reading-Web-Sprint-54-28-Days-Later.

Jhernandez moved this task to Needs Analysis on the Reading-Web-Sprint-54-28-Days-Later board.

Jhernandez added a subscriber: Jhernandez.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2015, 7:54 PM

Jhernandez mentioned this in T106272: Analyze Beta header numbers. Plan when/how to move it or remove it..Aug 13 2015, 7:55 PM

Jhernandez added a project: MobileFrontend.Aug 13 2015, 8:49 PM

Jhernandez set Security to None.

Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptAug 13 2015, 8:49 PM

Jdlrobson removed a project: Readers-Web-Backlog.Aug 13 2015, 11:21 PM

kaldari added a parent task: T108652: In mobile web Beta, sometimes search field is inoperable (especially on slow connections).Aug 14 2015, 8:46 PM

Jhernandez updated the task description. (Show Details)Aug 17 2015, 4:27 PM

Jdlrobson edited a custom field.Aug 17 2015, 4:28 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-54-28-Days-Later board.

phuedx updated the task description. (Show Details)Aug 17 2015, 4:28 PM

phuedx edited a custom field.

bmansurov claimed this task.Aug 20 2015, 1:13 AM

bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-54-28-Days-Later board.

@Jhernandez, should the header still be present in alpha? If we're not going to use it anymore, it may make sense to remove it from alpha too.

Change 232670 had a related patch set uploaded (by Bmansurov):
Remove the experimental header from alpha and beta

https://gerrit.wikimedia.org/r/232670

gerritbot added a project: Patch-For-Review.Aug 20 2015, 2:14 AM

bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-54-28-Days-Later board.Aug 20 2015, 2:16 AM

See https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/27969/consoleFull.

bmansurov moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-54-28-Days-Later board.Aug 20 2015, 5:41 PM

phuedx removed Story Points. assuming that was unintended?

bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-54-28-Days-Later board.Aug 21 2015, 1:27 AM

Change 232670 merged by jenkins-bot:
Remove the experimental header from alpha and beta

https://gerrit.wikimedia.org/r/232670

Diffusion mentioned this in rMEXTf6096f352ca9: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 21 2015, 3:53 PM

Jdlrobson mentioned this in rEMFR44165c116706: Remove the experimental header from alpha and beta.Aug 21 2015, 3:53 PM

bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-54-28-Days-Later board.Aug 21 2015, 3:55 PM

bmansurov moved this task from -1 (Needs More Work) to Ready for Signoff on the Reading-Web-Sprint-54-28-Days-Later board.

Verified on Beta Cluster, found that I had to hard refresh (clear caching) otherwise there was a frankenstein version of the header and menu.

Not sure if this is an issue for prod, thoughts?

Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-54-28-Days-Later board.Aug 21 2015, 4:32 PM

This has caused T109904 so moving back to sign off

Jdlrobson moved this task from Done to Ready for Signoff on the Reading-Web-Sprint-54-28-Days-Later board.Aug 21 2015, 9:46 PM

Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 23 2015, 12:34 AM

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-54-28-Days-Later board.Aug 24 2015, 8:35 AM

phuedx moved this task from Done to Ready for Signoff on the Reading-Web-Sprint-54-28-Days-Later board.

Jhernandez reopened this task as Open.Aug 24 2015, 9:25 AM

Jhernandez added a subtask: T109904: Regression: In stable last modified bar padding broken.

Jhernandez closed subtask T109904: Regression: In stable last modified bar padding broken as Resolved.Aug 25 2015, 11:08 AM

Jhernandez closed this task as Resolved.Aug 25 2015, 11:12 AM

Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-54-28-Days-Later board.