Page MenuHomePhabricator

ResourceLoader should log modules with error state
Closed, DuplicatePublic

Description

When there is module for which mw.loader.getState(m)='error', RL should log it to make debug easier.

Event Timeline

eranroz raised the priority of this task from to Needs Triage.
eranroz updated the task description. (Show Details)
eranroz subscribed.

Some extra explanation: For a small while there were some JS dependent resources not working such as VE (ext.visualEditor.desktopArticleTarget.init was in error state, and many others) in frwiki, enwiki and hewiki.
James suggested RL build got corrupted somehow. Whatever be the reason, it can be useful to log it both in client side (for debugging) and on server side (if not already done) to get timming of the issue and cross check it with other logs to get to the root cause.

Right now I'm debugging an issue where VE doesn't load because user.options (!) is in an error state. It would also be nice to log (or even be able to discover!) the reason why something is in an error state (exception, failed dependency, whatever).

By logging here you mean logging server-side in the debug log, or to the console? I imagine the latter is happening already.

to the console - e.g as you described in T110659

to the console - e.g as you described in T110659

If a module contains a syntax error, throws an exception in initial execution, or depends on a missing module, those error scenarios resulting in state=error already log to the console.

Only in case of server-side errors does it not do that. Merging T110659 to keep discussion central.