Page MenuHomePhabricator

[DisableAccount] Write a script to migrate disabled accounts with DisableAccount to blocked account
Closed, ResolvedPublic

Description

I think we also need a blocker about writing (and then running) a script to migrate current users who have been disabled via DisableAccount to blocks.

Event Timeline

Glaisher raised the priority of this task from to Lowest.
Glaisher updated the task description. (Show Details)
Glaisher raised the priority of this task from Lowest to Low.Aug 14 2015, 11:53 AM

Noting that password and email gets set to null with DisableAccount so these users would still be unable to login and it would still need a sysadmin to restore accounts for those disabled accounts.

Noting that password and email gets set to null with DisableAccount so these users would still be unable to login and it would still need a sysadmin to restore accounts for those disabled accounts.

And the indication that an account was DisableAccount'd is that 'inactive' group. Maybe we can just leave it then, and undeploy the extension?

In my opinion what we should do is to enable UserMerge in all private and fishbowl wikis. This make re-activate account easy - just create a new user and merge the old one to it.

An alternative idea (but much harder) is to create a new extension to copy an account (with password and email) from one wiki to another (and then they can override the orginal setting). This can even replace the current account request workflow of private and fishbowl wikis. No e-mails will be leaked.

Krenair renamed this task from Write a script to migrate disabled accounts with DisableAccount to blocked account to [DisableAccount] Write a script to migrate disabled accounts with DisableAccount to blocked account.Aug 18 2015, 4:10 AM
Krenair set Security to None.

Change 241512 had a related patch set uploaded (by Glaisher):
Add script to migrate disabled accounts to blocked accounts

https://gerrit.wikimedia.org/r/241512

Change 241512 merged by jenkins-bot:
Add script to migrate disabled accounts to blocked accounts

https://gerrit.wikimedia.org/r/241512

Is this now complete, but needs to be run in production?

It needs signoff from SuSa and/or Legal I think?

CommonSettings.php
// DO NOT DISABLE WITHOUT CONTACTING PHILIPPE / LEGAL!
// Installed by Andrew, 2011-04-26
if ( $wmgUseDisableAccount ) {
	require_once( "$IP/extensions/DisableAccount/DisableAccount.php" );
	$wgGroupPermissions['bureaucrat']['disableaccount'] = true;
}

It needs signoff from SuSa and/or Legal I think?

Definitely T106067: Undeploy DisableAccount extension needs sign-off, but this task as titled is complete, I assume. There's "write script", "run script", "disable extension".

Change 461702 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/DisableAccount@master] Check for users with "" for password and email too

https://gerrit.wikimedia.org/r/461702

Change 461704 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/DisableAccount@wmf/1.32.0-wmf.22] Check for users with "" for password and email too

https://gerrit.wikimedia.org/r/461704

Change 461702 merged by jenkins-bot:
[mediawiki/extensions/DisableAccount@master] Check for users with "" for password and email too

https://gerrit.wikimedia.org/r/461702

Change 461704 merged by jenkins-bot:
[mediawiki/extensions/DisableAccount@wmf/1.32.0-wmf.22] Check for users with "" for password and email too

https://gerrit.wikimedia.org/r/461704