Page MenuHomePhabricator
Create Task
Maniphest T109105

Service: Flatten media structure
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Currently the media object has properties for videos and images. Let's remove that distinction so we have more flexibility over the ordering of media items in galleries.
This will allow us to seamlessly switch over to T86954 without requiring changes on the client side.

Details

SubjectRepoBranchLines +/-
Eliminate image/video distinction in media objectmediawiki/services/mobileappsmaster+13 -8
Customize query in gerrit

Related Objects

Event Timeline

• bearND created this task.Aug 14 2015, 5:12 PM
• bearND raised the priority of this task from to High.
• bearND updated the task description. (Show Details)
• bearND added projects: Mobile-Content-Service, Wikipedia-Android-App-Backlog.
• bearND moved this task to Backlog on the Mobile-Content-Service board.
• bearND subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2015, 5:12 PM
• bearND moved this task from Needs Triage to Next Sprint on the Wikipedia-Android-App-Backlog board.Aug 14 2015, 5:13 PM
MBinder_WMF set Security to None.Aug 14 2015, 5:40 PM
MBinder_WMF edited a custom field.
Dbrant added a project: Mobile-App-Sprint-64-Android-Gadolinium.Aug 17 2015, 4:49 PM
Dbrant moved this task from Next Sprint to Current Sprint on the Wikipedia-Android-App-Backlog board.
• Mholloway claimed this task.Aug 18 2015, 3:29 PM
• Mholloway moved this task from To Do to Doing on the Mobile-App-Sprint-64-Android-Gadolinium board.
• bearND moved this task from Backlog to Doing on the Mobile-Content-Service board.Aug 18 2015, 5:24 PM
gerritbot subscribed.Aug 18 2015, 6:58 PM

Change 232320 had a related patch set uploaded (by Mholloway):
WIP: Flatten media structure

https://gerrit.wikimedia.org/r/232320

gerritbot added a project: Patch-For-Review.Aug 18 2015, 6:58 PM
• Mholloway moved this task from Doing to Code Review on the Mobile-App-Sprint-64-Android-Gadolinium board.Aug 18 2015, 9:06 PM
• Mholloway moved this task from Doing to Code Review on the Mobile-Content-Service board.
• Mholloway added a comment.Aug 19 2015, 12:24 AM

The two separate promises for images and video are still bothering me, but it seems necessitated by the API architecture for the moment.

That said, it looks like there are plans at some point on the horizon to deprecate prop=imageinfo and prop=videoinfo in favor of a (to-be-written) prop=fileinfo module that could presumably handle both.

• Mholloway added a comment.Aug 19 2015, 12:43 AM

Source for that claim: https://www.mediawiki.org/wiki/API/Architecture_work/Planning#Rewrite_prop.3Dimageinfo_from_scratch_as_prop.3Dfileinfo

gerritbot added a comment.Aug 21 2015, 10:27 AM

Change 232320 merged by Mobrovac:
Eliminate image/video distinction in media object

https://gerrit.wikimedia.org/r/232320

• Mholloway moved this task from Code Review to Ready for Signoff on the Mobile-App-Sprint-64-Android-Gadolinium board.Aug 21 2015, 12:51 PM
• Mholloway moved this task from Code Review to To Deploy on the Mobile-Content-Service board.
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Sprint-64-Android-Gadolinium board.Aug 24 2015, 3:13 PM
• bearND closed this task as Resolved.Aug 27 2015, 3:07 AM
• Deskana moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Aug 29 2015, 2:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL