Page MenuHomePhabricator
Create Task
Maniphest T109110

Can't load images when cookies are disabled
Closed, ResolvedPublic
Actions

Description

(via https://twitter.com/baptx/status/589502685260472322)

To reproduce:

  1. Disable cookies. (In Firefox: about:config, set network.cookie.cookieBehavior to 2.)
  2. Navigate to an article page with images.
  3. Try to click on any of the images.

Expected result: MMV is launched.
Actual result: Nothing happens.

Looks to be an error in mmv.bootstrap.autostart.

Details

SubjectRepoBranchLines +/-
Work even when cookies are disabledmediawiki/extensions/MultimediaViewermaster+14 -3
Work even when cookies are disabledmediawiki/extensions/MultimediaViewerwmf/1.26wmf18+14 -3
Customize query in gerrit

Related Objects

Event Timeline

ori created this task.Aug 14 2015, 5:46 PM
ori raised the priority of this task from to Unbreak Now!.
ori updated the task description. (Show Details)
ori added a project: MediaViewer.
ori subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 14 2015, 5:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Aug 14 2015, 6:18 PM

Change 231604 had a related patch set uploaded (by Ori.livneh):
Work even when cookies are disabled

https://gerrit.wikimedia.org/r/231604

Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 14 2015, 6:18 PM
gerritbot added a project: Patch-For-Review.Aug 14 2015, 6:18 PM
gerritbot added a comment.Aug 14 2015, 6:22 PM

Change 231606 had a related patch set uploaded (by Ori.livneh):
Work even when cookies are disabled

https://gerrit.wikimedia.org/r/231606

gerritbot added a comment.Aug 14 2015, 6:27 PM

Change 231606 merged by Ori.livneh:
Work even when cookies are disabled

https://gerrit.wikimedia.org/r/231606

ori mentioned this in rMW9ee0437bc6b4: Updated mediawiki/core Project: mediawiki/extensions/MultimediaViewer….Aug 14 2015, 6:27 PM
ori mentioned this in rEMMV645b6c9e93fa: Work even when cookies are disabled.
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 14 2015, 7:00 PM
gerritbot added a comment.Aug 14 2015, 7:09 PM

Change 231604 merged by jenkins-bot:
Work even when cookies are disabled

https://gerrit.wikimedia.org/r/231604

ori mentioned this in rMEXT1ace0fe3de2e: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer….Aug 14 2015, 7:09 PM
ori mentioned this in rEMMV1a0ee6d2a17c: Work even when cookies are disabled.
ori closed this task as Resolved.Aug 14 2015, 7:14 PM
ori claimed this task.
• Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 14 2015, 8:00 PM
• MZMcBride subscribed.Aug 16 2015, 10:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL