Page MenuHomePhabricator

Remove queue name from OAuth consumer management URL
Closed, ResolvedPublic

Description

Consumer management URLs are of the form Special:OAuthManageConsumers/<stagekey>/<appid> where <stagekey> is something like "rejected" or "proposed". Having this component is not useful: it is not actually used for anything, and it just leads to misunderstandings in edge cases (what if a message sends someone to /proposed but the application has been rejected since then? In other words, this make it impossible to link to the management page without knowing the state of the consumer (or faking it, but then there is no point in having it).

Event Timeline

Tgr created this task.Aug 15 2015, 1:15 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a subscriber: Tgr.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2015, 1:15 AM
Tgr updated the task description. (Show Details)Aug 15 2015, 1:16 AM
Tgr set Security to None.
Tgr added a comment.Aug 15 2015, 1:22 AM

It's used in the patch in T63000 but that could probably just be replaced by returning to whichever queue matches the application's old state.

Change 231746 had a related patch set uploaded (by Gergő Tisza):
Remove queue name from OAuth consumer management URL

https://gerrit.wikimedia.org/r/231746

Change 231746 merged by jenkins-bot:
Remove queue name from OAuth consumer management URL

https://gerrit.wikimedia.org/r/231746

Tgr closed this task as Resolved.Jul 29 2016, 6:37 AM
Tgr claimed this task.