Social network icons are reversed when telling the users for the first time that they can share
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Amire80
	Aug 16 2015, 8:05 AM

Description

To reproduce:

Set your device to Hebrew.
Install the app.
Open the app and go to an article.
Select some text. A blue-color bubble will pop up near the share icon at the top, and it will suggest the user to share the selected text on social networks.

The icons in this bubble are horizontally mirrored. This is not a disaster for Twitter, where the bird just looks the other way, but for Facebook, the [f] icon is reversed an this definitely wrong. There's no reason at all to mirror these icons.

I couldn't take a screenshot, because the bubble disappears when I try to swipe, but the description should be enough.

Details

	Subject	Repo	Branch	Lines +/-
	Remove RTL icons for social networks, mark SVGs as noflip.	apps/android/wikipedia	master	+0 -0

Customize query in gerrit

Related Objects

Mentioned In: rAPAWfde676e7f20c: Remove RTL icons for social networks, mark SVGs as noflip.

Event Timeline

Amire80 created this task.Aug 16 2015, 8:05 AM

Amire80 raised the priority of this task from to Medium.

Amire80 updated the task description. (Show Details)

Amire80 added projects: Wikipedia-Android-App-Backlog, RTL, Design.

Amire80 subscribed.

Restricted Application added a project: I18n. · View Herald TranscriptAug 16 2015, 8:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 233090 had a related patch set uploaded (by Deskana):
Remove RTL icons for social networks, mark SVGs as noflip.

https://gerrit.wikimedia.org/r/233090

gerritbot added a project: Patch-For-Review.Aug 22 2015, 5:04 AM

@Amire80 Thanks for the report. The above patch deletes the RTL icons for the social networks (which makes the app fall back to using the non-RTL icons, which as you note is correct in this case), and marks the SVGs that generate the icons as noflip (which ensures that RTL versions of these icons will not be generated in the future, meaning that the fallback to the non-RTL version will always take place). In short, this should fix the problem.

• Deskana claimed this task.Aug 22 2015, 5:34 AM

• Deskana set Security to None.

Change 233090 merged by jenkins-bot:
Remove RTL icons for social networks, mark SVGs as noflip.

https://gerrit.wikimedia.org/r/233090

• Deskana mentioned this in rAPAWfde676e7f20c: Remove RTL icons for social networks, mark SVGs as noflip..Aug 24 2015, 1:15 PM

@Amire80 Should be fixed in alpha now. Thanks!

Dbrant moved this task from Needs Triage to Current Sprint on the Wikipedia-Android-App-Backlog board.Aug 26 2015, 12:53 PM

• Deskana moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Aug 29 2015, 2:39 AM