Page MenuHomePhabricator
Create Task
Maniphest T109277

[EPIC]: Use core watchlist code for mobile experience
Closed, ResolvedPublic
Actions

Assigned To
Jdlrobson
Authored By
• Jhernandez
Aug 17 2015, 11:56 AM
Tags
Referenced Files
F8635058: Screen Shot 2017-07-06 at 1.20.56 PM.png
Jul 6 2017, 8:22 PM
F8635060: Screen Shot 2017-07-06 at 1.20.17 PM.png
Jul 6 2017, 8:22 PM
Subscribers
Aklapper
Dvorapa
eranroz
Florian
Izno
Jdlrobson
• JKatzWMF
View All 17 Subscribers

Description

Problem

The MobileFrontend extension currently tries to mimic the watchlist in core but fails due to the fact the special watchlist class mixes rendering with model generation. Ideally it should be possible to skin the data by creating this separation.

Recreating the watchlist for mobile is very wasteful.
It causes additional work for other teams (see T159793).

The Watchlist special page also handles various user preferences which are currently overlooked by the mobile version.

Differences between mobile and desktop skinning

Screen Shot 2017-07-06 at 1.20.56 PM.png (619×679 px, 68 KB)

Screen Shot 2017-07-06 at 1.20.17 PM.png (505×1 px, 297 KB)

As you can be seen the positions of elements are extremely different. Touch areas are different. It's impossible to use the same HTML for both designs without a fundamental change to the design.

roll out plan

  • Align the HTML/CSS for mobile and desktop.
  • enable for all logged in users on English Wikipedia
  • Enable on all projects
  • Decommission associated code (will be done in T365769)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[Config] Match production configurationmediawiki/extensions/MobileFrontendmaster+2 -2
Always use desktop watchlist HTML on mobileoperations/mediawiki-configmaster+1 -10
Enable desktop watchlist HTML on mobileoperations/mediawiki-configmaster+6 -0
Drop responsive behaviourmediawiki/skins/MinervaNeuewmf/1.43.0-wmf.5+0 -9
Drop responsive behaviourmediawiki/skins/MinervaNeuemaster+0 -9
Enable desktop watchlist on beta cluster, clean up old referencesoperations/mediawiki-configmaster+2 -29
Apply history styles to watchlistmediawiki/skins/MinervaNeuemaster+135 -61
[Proof of concept] Drop the Mobile special pagesmediawiki/extensions/MobileFrontendmaster+18 -2 K
Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versionsmediawiki/extensions/MobileFrontendmaster+103 -1 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
 ResolvedJdlrobsonT109277 [EPIC]: Use core watchlist code for mobile experience
 DeclinedNoneT70367 Mobile Watchlist does not take into account preference value of expand/aggregation into account
 DeclinedNoneT90818 Special:EditWatchlist in mobile should use server side templating
 DeclinedNoneT70365 Hide bot edits from the watch list not taken into account
 DeclinedNoneT90819 SpecialMobileWatchlist, SpecialMobileContributions, SpecialMobileHistory should not use MobileSpecialPageFeed
 ResolvedJdlrobsonT94505 Infinite scrolling Special:EditWatchlist on mobile incorrectly identifies pages as not existing.
ResolvedJdlrobsonT101453 Cannot see entire contents of Special:EditWatchlist
 Duplicate• JhernandezT70368 Add 'more' button at end of watch list feed, to look further in history
 DeclinedNoneT58817 Watchlist features available on desktop that aren't on mobile yet (tracking)
 ResolvedNoneT54495 Mobile watchlist has no concept of unread/read changes.
 DeclinedNoneT58812 Mobile watchlist just says "Anonymous", doesn't show IP address in overview
 ResolvedNoneT58816 Watchlist: No option to show only most recent change
 DeclinedNoneT69799 Mobile watchlist should follow the same Show/Hide preferences as the desktop watchlist
 DuplicateNoneT156962 Default watchlistview in mobilefrontend should be feed not the list
 DuplicateNoneT69526 MobileFrontend watchlist should default to a chronological rather than alphabetical listing
 ResolvedJdlrobsonT88270 Special:Watchlist should be the default not Special:EditWatchlist when you click watchlist in left menu
 DuplicateNoneT111074 Watchlist query continuation handling
 DeclinedNoneT198807 Unseen changes on the Watchlist are not highlighted/bold on mobile site
 DeclinedNoneT223566 Topic: edits should appear in Talk tab in Mobile Watchlist
 DeclinedBUG REPORTJdlrobsonT229716 [BUG] Watchlist link feed/list preference not honoured when following user Menu watchlist link.
 DeclinedNoneT233845 Non-AMC Mobile watchlist shows opaque names for Structured Discussion topics
 ResolvedBUG REPORTJdlrobsonT263633 Mobile Special:EditWatchlist displays item IDs instead of labels
 ResolvedBUG REPORTJdlrobsonT336938 Mobile watchlist in "List" view looks different after scrolling past "more"

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson moved this task from Untriaged to Epics on the MobileFrontend board.Jul 13 2017, 5:57 PM
Jdlrobson merged a task: T108290: Mobile watchlist: add support for showing only latest edit.Jul 19 2017, 1:24 AM
Jdlrobson added a subscriber: eranroz.
• Jhernandez unsubscribed.Aug 9 2017, 5:43 PM
Jdlrobson mentioned this in T174194: Display user account blocks in mobile view on Special:Contributions.Aug 28 2017, 3:37 PM
Jdlrobson added a subtask: T198807: Unseen changes on the Watchlist are not highlighted/bold on mobile site.Jul 5 2018, 3:31 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson mentioned this in T198807: Unseen changes on the Watchlist are not highlighted/bold on mobile site.
Izno subscribed.Jul 24 2018, 4:37 PM
Jdlrobson moved this task from Epics to MobileFrontend Special Pages on the MobileFrontend board.Oct 18 2018, 6:58 PM
Jdlrobson edited projects, added MobileFrontend (MobileFrontend Special Pages); removed MobileFrontend.
Dvorapa subscribed.Nov 18 2018, 7:14 PM
Jdlrobson moved this task from Backlog to Watchlist on the MobileFrontend (MobileFrontend Special Pages) board.Feb 21 2019, 6:32 PM
gerritbot added a comment.Mar 29 2019, 12:19 AM

Change 499864 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

gerritbot added a project: Patch-For-Review.Mar 29 2019, 12:19 AM
gerritbot added a comment.Apr 4 2019, 11:37 PM

Change 499864 abandoned by Jdlrobson:
Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

Jdlrobson added a subtask: T223566: Topic: edits should appear in Talk tab in Mobile Watchlist.Aug 1 2019, 4:15 PM
Jdlrobson added a subtask: T229716: [BUG] Watchlist link feed/list preference not honoured when following user Menu watchlist link..Aug 5 2019, 2:40 PM
Jdlrobson added a subtask: T233845: Non-AMC Mobile watchlist shows opaque names for Structured Discussion topics.Sep 25 2019, 9:05 PM
Jdlrobson mentioned this in T233845: Non-AMC Mobile watchlist shows opaque names for Structured Discussion topics.
Jdlrobson closed subtask T229716: [BUG] Watchlist link feed/list preference not honoured when following user Menu watchlist link. as Declined.Jan 17 2020, 10:41 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 17 2020, 10:41 PM
Lucas_Werkmeister_WMDE mentioned this in T263633: Mobile Special:EditWatchlist displays item IDs instead of labels.Sep 23 2020, 5:19 PM
Jdlrobson added a subtask: T263633: Mobile Special:EditWatchlist displays item IDs instead of labels.Sep 30 2020, 5:45 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 30 2020, 6:10 PM
Jdlrobson closed subtask T198807: Unseen changes on the Watchlist are not highlighted/bold on mobile site as Declined.Apr 30 2021, 8:38 PM
Jdlrobson edited projects, added Web-Team-Backlog-Archived (Needs Prioritization (Tech)); removed Web-Team-Backlog-Archived (Tracking).Dec 7 2021, 7:38 PM
Jdlrobson moved this task from Backlog to Simplify MobileFrontend on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Dec 8 2021, 7:42 PM
Jdlrobson moved this task from Simplify MobileFrontend to [active] Remove Special:MobileContributions on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Dec 9 2021, 5:42 PM
Jdlrobson moved this task from [active] Remove Special:MobileContributions to Remove mobile Watchlist special page on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Jan 11 2022, 1:54 AM
gerritbot added a comment.Jan 20 2022, 12:10 AM

Change 755510 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] [Proof of concept] Drop the Mobile special pages

https://gerrit.wikimedia.org/r/755510

gerritbot added a project: Patch-For-Review.Jan 20 2022, 12:10 AM
PatchDemoBot added a comment.Jan 26 2022, 12:56 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/5b440214c6/w/

PatchDemoBot added a comment.Jan 26 2022, 1:32 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d6efd56b19/w/

PatchDemoBot added a comment.Jan 26 2022, 1:38 AM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d6efd56b19/w/

gerritbot added a comment.Jan 27 2022, 8:29 PM

Change 755510 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] [Proof of concept] Drop the Mobile special pages

Reason:

Not actively working on this. Some of this work will be realized in https://phabricator.wikimedia.org/T300185

https://gerrit.wikimedia.org/r/755510

xSavitar subscribed.Mar 8 2022, 6:45 PM
Jdlrobson mentioned this in T210168: [EPIC] Get rid of MobileFrontend's special pages for changes list where equivalents exist in core.Mar 30 2022, 10:36 PM
PatchDemoBot added a comment.Oct 18 2022, 2:03 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/5b440214c6/w/

Jdlrobson mentioned this in T177260: Rewrite disabled MobileFrontend browser tests to phpunit tests and Node.js browser tests.Feb 28 2023, 9:32 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 28 2023, 10:10 PM
Jdlrobson added a subtask: T336938: Mobile watchlist in "List" view looks different after scrolling past "more".May 26 2023, 4:34 PM
Jdlrobson changed the status of subtask T263633: Mobile Special:EditWatchlist displays item IDs instead of labels from Open to Stalled.Dec 13 2023, 10:36 PM
Jdlrobson moved this task from Remove mobile Watchlist special page to Future Unplanned on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Jan 8 2024, 10:44 PM
gerritbot added a comment.Mar 22 2024, 8:27 PM

Change #1013600 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Apply history styles to watchlist

https://gerrit.wikimedia.org/r/1013600

gerritbot added a project: Patch-For-Review.Mar 22 2024, 8:27 PM
Jdlrobson moved this task from Future Unplanned to Remove MobileFrontend special pages on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Mar 22 2024, 9:07 PM
gerritbot added a comment.Apr 1 2024, 12:00 PM

Change #1013600 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Apply history styles to watchlist

https://gerrit.wikimedia.org/r/1013600

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Apr 1 2024, 1:00 PM
gerritbot added a comment.Apr 1 2024, 10:57 PM

Change #1016022 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable desktop watchlist on beta cluster, clean up old references

https://gerrit.wikimedia.org/r/1016022

Jdlrobson mentioned this in T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css.Apr 2 2024, 7:43 AM
gerritbot added a comment.Apr 15 2024, 8:17 PM

Change #1016022 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable desktop watchlist on beta cluster, clean up old references

https://gerrit.wikimedia.org/r/1016022

Stashbot added a comment.Apr 15 2024, 8:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T20:19:20Z] <kindrobot@deploy1002> Started scap: Backport for [[gerrit:1016022|Enable desktop watchlist on beta cluster, clean up old references (T109277)]], [[gerrit:1019857|Enable night mode on template namespace]]

Stashbot added a comment.Apr 15 2024, 8:21 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T20:21:56Z] <kindrobot@deploy1002> jdlrobson and kindrobot: Backport for [[gerrit:1016022|Enable desktop watchlist on beta cluster, clean up old references (T109277)]], [[gerrit:1019857|Enable night mode on template namespace]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Apr 15 2024, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-15T20:36:26Z] <kindrobot@deploy1002> Finished scap: Backport for [[gerrit:1016022|Enable desktop watchlist on beta cluster, clean up old references (T109277)]], [[gerrit:1019857|Enable night mode on template namespace]] (duration: 17m 06s)

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 7:07 PM
gerritbot added a comment.May 15 2024, 2:34 PM

Change #1031943 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Drop responsive behaviour

https://gerrit.wikimedia.org/r/1031943

gerritbot added a project: Patch-For-Review.May 15 2024, 2:34 PM
gerritbot added a comment.May 17 2024, 4:26 PM

Change #1032808 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.5] Drop responsive behaviour

https://gerrit.wikimedia.org/r/1032808

gerritbot added a comment.May 17 2024, 4:30 PM

Change #1032833 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable desktop watchlist HTML on mobile

https://gerrit.wikimedia.org/r/1032833

gerritbot added a comment.May 17 2024, 4:51 PM

Change #1031943 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Drop responsive behaviour

https://gerrit.wikimedia.org/r/1031943

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 17 2024, 5:00 PM
gerritbot added a comment.May 21 2024, 8:24 PM

Change #1032808 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.5] Drop responsive behaviour

https://gerrit.wikimedia.org/r/1032808

gerritbot added a comment.May 21 2024, 8:31 PM

Change #1032833 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable desktop watchlist HTML on mobile

https://gerrit.wikimedia.org/r/1032833

Maintenance_bot removed a project: Patch-For-Review.May 21 2024, 8:31 PM
Stashbot added a comment.May 21 2024, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:33:26Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1032808|Drop responsive behaviour (T109277)]], [[gerrit:1034168|Decouple MFUseDesktopSpecialWatchlistPage from EditWatchlist page]], [[gerrit:1032833|Enable desktop watchlist HTML on mobile (T109277)]], [[gerrit:1029506|Don't define wmgUseListings, no longer read]]

Stashbot added a comment.May 21 2024, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:36:09Z] <jforrester@deploy1002> jforrester and jdlrobson: Backport for [[gerrit:1032808|Drop responsive behaviour (T109277)]], [[gerrit:1034168|Decouple MFUseDesktopSpecialWatchlistPage from EditWatchlist page]], [[gerrit:1032833|Enable desktop watchlist HTML on mobile (T109277)]], [[gerrit:1029506|Don't define wmgUseListings, no longer read]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

gerritbot added a comment.May 21 2024, 8:50 PM

Change #1034584 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Always use desktop watchlist HTML on mobile

https://gerrit.wikimedia.org/r/1034584

gerritbot added a project: Patch-For-Review.May 21 2024, 8:50 PM
Stashbot added a comment.May 21 2024, 8:51 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-21T20:51:43Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:1032808|Drop responsive behaviour (T109277)]], [[gerrit:1034168|Decouple MFUseDesktopSpecialWatchlistPage from EditWatchlist page]], [[gerrit:1032833|Enable desktop watchlist HTML on mobile (T109277)]], [[gerrit:1029506|Don't define wmgUseListings, no longer read]] (duration: 18m 17s)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.5; 2024-05-14); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 21 2024, 9:00 PM
gerritbot added a comment.May 21 2024, 9:11 PM

Change #1034590 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Dismantle Special:Watchlist and associated code

https://gerrit.wikimedia.org/r/1034590

Jdlrobson updated the task description. (Show Details)May 21 2024, 9:18 PM
gerritbot added a comment.May 23 2024, 8:39 PM

Change #1034584 merged by jenkins-bot:

[operations/mediawiki-config@master] Always use desktop watchlist HTML on mobile

https://gerrit.wikimedia.org/r/1034584

Stashbot added a comment.May 23 2024, 8:39 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-23T20:39:32Z] <jsn@deploy1002> Started scap: Backport for [[gerrit:1034584|Always use desktop watchlist HTML on mobile (T109277)]]

gerritbot added a comment.May 23 2024, 8:41 PM

Change #1035569 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] [Config] Match production configuration

https://gerrit.wikimedia.org/r/1035569

Stashbot added a comment.May 23 2024, 8:42 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-23T20:42:03Z] <jsn@deploy1002> jdlrobson and jsn: Backport for [[gerrit:1034584|Always use desktop watchlist HTML on mobile (T109277)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.May 23 2024, 8:55 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-23T20:55:56Z] <jsn@deploy1002> Finished scap: Backport for [[gerrit:1034584|Always use desktop watchlist HTML on mobile (T109277)]] (duration: 16m 23s)

gerritbot added a comment.May 23 2024, 9:40 PM

Change #1035569 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] [Config] Match production configuration

https://gerrit.wikimedia.org/r/1035569

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.7; 2024-05-28); removed MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 23 2024, 10:00 PM
Jdlrobson closed this task as Resolved.May 23 2024, 10:29 PM
Jdlrobson claimed this task.
Jdlrobson added a subscriber: jsn.sherman.

No pages in Wikimedia production use this code now. Removal of the code will be handled in T365769. Thanks @jsn.sherman for all your support on this one!

Jdlrobson updated the task description. (Show Details)May 23 2024, 10:29 PM
Jdlrobson mentioned this in T364395: Watchlist tabs display the very same content.
Jdlrobson mentioned this in T237204: Make the new design of mobile watchlist opt-in.May 23 2024, 10:31 PM
Jdlrobson mentioned this in T220678: On normal mobile view of Wikimedia Commons, uploaded files are not listed on watchlist as "Pages".
Jdlrobson mentioned this in T98724: Flow topics in mobile watchlist should be human readable.May 23 2024, 10:34 PM
Jdlrobson mentioned this in T159793: Handle MobileWatchlist in regards to Edit Review Improvements.May 23 2024, 10:37 PM
Jdlrobson closed subtask T223566: Topic: edits should appear in Talk tab in Mobile Watchlist as Declined.
Jdlrobson mentioned this in T223566: Topic: edits should appear in Talk tab in Mobile Watchlist.
Jdlrobson closed subtask T233845: Non-AMC Mobile watchlist shows opaque names for Structured Discussion topics as Declined.
Jdlrobson closed subtask T336938: Mobile watchlist in "List" view looks different after scrolling past "more" as Resolved.Jul 26 2024, 12:39 AM
Jdlrobson closed subtask T263633: Mobile Special:EditWatchlist displays item IDs instead of labels as Resolved.Aug 27 2024, 8:31 PM
Izno added a comment.EditedOct 18 2024, 8:23 PM

SpecialMobileEditWatchlist.php still appears to exist, with several other hangers on in codesearch. I think this is currently inaccessible except by any prior links that might be lying around?

Way I got here: went to update Extension:MF to remove the "we've got specialer special pages", then saw the hooks in the infobox.

Jdlrobson added a comment.Oct 19 2024, 12:17 AM
In T109277#10243460, @Izno wrote:

SpecialMobileEditWatchlist.php still appears to exist, with several other hangers on in codesearch. I think this is currently inaccessible except by any prior links that might be lying around?

Way I got here: went to update Extension:MF to remove the "we've got specialer special pages", then saw the hooks in the infobox.

That page is still in use. T266065 has the details about what we're trying to do to get rid of it. The complexity of this one is that on mobile it's being used as a reading list feature by editors with 0 edit count so we can't just give them the desktop watchlist page in current form.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits