Page MenuHomePhabricator

[EPIC]: Use core watchlist code for mobile experience
Open, NormalPublic

Description

Problem

The MobileFrontend extension currently tries to mimic the watchlist in core but fails due to the fact the special watchlist class mixes rendering with model generation. Ideally it should be possible to skin the data by creating this separation.

Recreating the watchlist for mobile is very wasteful.
It causes additional work for other teams (see T159793).

The Watchlist special page also handles various user preferences which are currently overlooked by the mobile version.

Differences between mobile and desktop skinning



As you can be seen the positions of elements are extremely different. Touch areas are different. It's impossible to use the same HTML for both designs without a fundamental change to the design.

Solution 1

Use api.
Construct an ApiMain with a derived RequestContext

Hit the API to source the data for rendering.
Being driven by the API would also help resolve T111074 and T70368

Note: Use of FauxRequest seems to be frowned upon... see T169266

Solution 2

We do the separation in SpecialWatchlist. There should be a simple method render which is passed data or a model and renders it.

Make use of WatchedItemQueryService.php

Tangential:
It would be useful if SpecialWatchlist::outputChangesList in core was refactored to use this. It would make skinning a lot easier....

acceptance criteria

The following user preferences should be honoured

  • Mobile watchlist should follow the same Show/Hide preferences as the desktop watchlist (see T69799 for more details)
  • Mobile Watchlist does not take into account preference value of expand/aggregation into account (see T70367)
  • Hide bot edits from the watch list not taken into account (see T70365)
  • No logic for unseen notifications
  • Pagination should be mor (was T111074)

todo

  • add screenshots showing desktop watchlist skinned in Minerva and mobile watchlist
  • suggest architecture diagram
  • tag with mediawiki core team
  • rfc?

Related Objects

StatusAssignedTask
OpenNone
OpenNone
DeclinedNone
DeclinedNone
DeclinedNone
DeclinedNone
ResolvedJdlrobson
ResolvedJdlrobson
DuplicateJhernandez
DeclinedNone
ResolvedNone
DeclinedNone
ResolvedNone
DeclinedNone
DuplicateNone
DuplicateNone
ResolvedJdlrobson
DuplicateNone
OpenNone

Event Timeline

Jhernandez raised the priority of this task from to Low.
Jhernandez updated the task description. (Show Details)
Jhernandez added projects: MobileFrontend, Epic.
Jhernandez added subscribers: Jhernandez, Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2015, 11:56 AM
Jdlrobson renamed this task from [EPIC]: Improve mobile watchlist to [EPIC]: Improve mobile watchlist / use core watchlist code for mobile experience.Dec 3 2015, 11:46 PM
Jdlrobson set Security to None.
Jdlrobson renamed this task from [EPIC]: Improve mobile watchlist / use core watchlist code for mobile experience to [EPIC]: Use core watchlist code for mobile experience.May 22 2017, 9:34 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)May 22 2017, 9:59 AM
Jdlrobson raised the priority of this task from Low to Normal.May 25 2017, 10:34 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)May 26 2017, 6:22 PM
Jdlrobson moved this task from Backlog to Later on the Readers-Web-Backlog (Tracking) board.
Jdlrobson updated the task description. (Show Details)Jul 6 2017, 8:18 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: phuedx, Stryn, PamD and 8 others.
Jdlrobson updated the task description. (Show Details)Jul 6 2017, 8:22 PM
phuedx removed a subscriber: phuedx.Jul 7 2017, 8:57 AM
Jdlrobson moved this task from Backlog to Epics on the MobileFrontend board.Jul 13 2017, 5:57 PM
Izno added a subscriber: Izno.Jul 24 2018, 4:37 PM

Change 499864 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

Change 499864 abandoned by Jdlrobson:
Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864