Page MenuHomePhabricator

Promote fontchanger to stable (in feature branch)
Closed, ResolvedPublic2 Story Points

Description

Background:

In order to provide a better reading experience through a large set of users, we want to be able to allow users to increase and decrease the font size of articles.

In mobile web beta in the settings menu there is a font changer which allows the user to increase font size via JavaScript.

Acceptance criteria

  • font changer is promoted to stable (turning on beta does not provide access to the feature) in the feature branch 'specialpages'
  • font changer appears in "Settings" tab separate from beta

Additional notes

Review notes (which are likely to be outdated) in T109363
Do not deploy this until T169369: Change font size controls to use small, regular, large and extra large buckets and additional QA is complete

Related Objects

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: MobileFrontend.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2015, 7:47 PM
Jhernandez triaged this task as Normal priority.Aug 19 2015, 5:12 PM
Jhernandez set Security to None.
phuedx removed a subscriber: phuedx.Apr 19 2017, 5:11 AM
MaxSem removed a subscriber: MaxSem.Jun 30 2017, 9:25 PM
Nirzar added a subscriber: Nirzar.Jul 7 2017, 7:12 PM

Note: T169379 is blocker for this task.

The fontchanger currently changes the font of all paragraphs. It however doesn't change the font size of image captions and headings e.g. h2

@Nirzar is this intentional?

not sure. who designed this? we don't have any documentation by whoever worked on it I guess.

if I have to take a call on this. I would say we should change all font sizes except for H2 because H2 is bit of a UI element as well as content element and being interactive, it would be odd to have space taken up by it on screen. specially for long H2s

It was a volunteer effort. Web has had nothing to do with this except code review. It would sense to actually talk through this feature and what impact it should have one the ui before commiting to promoting it! For instance it doesn't apply to overlays!

kaldari removed a subscriber: kaldari.Oct 30 2017, 9:52 PM
ovasileva updated the task description. (Show Details)Dec 6 2017, 5:37 PM
ovasileva updated the task description. (Show Details)Dec 6 2017, 5:40 PM
Jdlrobson updated the task description. (Show Details)Dec 6 2017, 5:41 PM
ovasileva renamed this task from [EPIC] Promote fontchanger to stable to Promote fontchanger to stable (in feature branch).Dec 6 2017, 5:43 PM
ovasileva set the point value for this task to 2.Dec 6 2017, 5:48 PM

Change 396284 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@specialpages] Promote expand all sections and fontchanger to stable

https://gerrit.wikimedia.org/r/396284

Change 396284 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@specialpages] Promote expand all sections and fontchanger to stable

https://gerrit.wikimedia.org/r/396284

pmiazga assigned this task to Nirzar.Dec 20 2017, 6:09 PM