Enabling bucketing on QuickSurvey
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 18 2015, 9:05 PM

Description

Given I have a survey defined I should be able to configure a sample rate for the number of users who see the survey.
If 0.5, 50% of users see the survey
if 0 0% of users see the survey
if 100% all users see the survey.

We should make use of the new experiments API that @phuedx is moving into core.

Details

	Subject	Repo	Branch	Lines +/-
	Setup survey bucketing and add browser tests	mediawiki/extensions/QuickSurveys	dev	+144 -58

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T96785 In-channel feedback with star rating / picklist (and on apps, simple text entry?) and backend de-spam
Resolved	• Jhernandez	T104439 [GOAL]: Develop a mechanism for quick surveys on desktop + mobile
Duplicate	None	T107594 An enabled configured external survey shows on the desktop site.
Resolved	• bmansurov	T107589 An enabled configured external survey shows on the mobile version of the site
Resolved	Jdlrobson	T107592 An enabled configured quick survey shows on the mobile version of the site
Resolved	• rmoen	T109518 Enabling bucketing on QuickSurvey
Resolved	phuedx	T109010 Upstream experiments code from MobileFrontend to core.

Event Timeline

Jdlrobson created this task.Aug 18 2015, 9:05 PM

Jdlrobson claimed this task.

Jdlrobson removed Jdlrobson as the assignee of this task.

Jdlrobson raised the priority of this task from to Medium.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Reading-Web-Sprint-54-28-Days-Later, QuickSurveys.

Jdlrobson added a subtask: T109010: Upstream experiments code from MobileFrontend to core..

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-54-28-Days-Later board.

Jdlrobson set Security to None.

Jdlrobson added subscribers: • rmoen, • bmansurov, gerritbot and 8 others.

This just popped in the todo column. We didn't estimate this. Ok to work on ? @Jhernandez @Jdlrobson

It's a subtask of T107592 and is needed to complete T107592 which we estimated.

• rmoen claimed this task.Aug 20 2015, 10:30 PM

• rmoen moved this task from To Do to Doing on the Reading-Web-Sprint-54-28-Days-Later board.

Change 233763 had a related patch set uploaded (by Robmoen):
Setup survey bucketing

https://gerrit.wikimedia.org/r/233763

gerritbot added a project: Patch-For-Review.Aug 25 2015, 6:11 PM

• rmoen moved this task from Doing to Code Review on the Reading-Web-Sprint-54-28-Days-Later board.Aug 25 2015, 8:47 PM

Given T110198 I would say this is not mergeable until it has some browser tests accompanying them.

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-54-28-Days-Later board.Aug 25 2015, 10:09 PM

@Jdlrobson for some reason the first step in the tests is failing for me.

Given the quick survey test pages are installed # features/support/step_definitions/common_steps.rb:1
  unexpected HTTP response (404) (MediawikiApi::HttpError)

It must be my environment. I will keep fiddling with it.
However, I have added tests that should work. Can someone confirm?

Sounds like you need export MEDIAWIKI_API_URL=http://127.0.0.1:8888/w/api.php
Tests currently do not work for me.
Then I should see the survey is failing for all of them