Page MenuHomePhabricator
Create Task
Maniphest T109529

Cursor appears over the drop down menu for text styling in Mobile VisualEditor
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Type something in a page using mobile VisualEditor
  2. Now tap on the text formatting icon from the toolbar

Observe that the cursor is appearing over the menu.

11872676_10153167928057879_62807372_n.jpg (960×540 px, 41 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Deactivate the surface when the toolbar is activeVisualEditor/VisualEditormaster+18 -1
Update VE core submodule to master (aac36db2c)mediawiki/extensions/VisualEditormaster+1 -1
Update OOUI to v0.28.0mediawiki/coremaster+314 -321
Mobile: Deactivate the surface when the toolbar is activemediawiki/extensions/VisualEditormaster+10 -0
Toolbar: Emit events to let user know if toolbar popups are visibleoojs/uimaster+46 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Aug 18 2015, 10:08 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added projects: VisualEditor, VisualEditor-MediaWiki-Mobile.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2015, 10:08 PM
Jdforrester-WMF triaged this task as Low priority.Aug 25 2015, 7:05 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
gerritbot subscribed.Aug 6 2018, 4:50 PM

Change 450612 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Toolbar: Emit events to let user know if toolbar popups are visible

https://gerrit.wikimedia.org/r/450612

gerritbot added a project: Patch-For-Review.Aug 6 2018, 4:50 PM
gerritbot added a comment.Aug 6 2018, 4:52 PM

Change 450616 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Mobile: Deactivate the surface when the toolbar is active

https://gerrit.wikimedia.org/r/450616

Esanders mentioned this in T201329: Mobile: Hide keyboard while menus are open.Aug 6 2018, 4:54 PM
gerritbot added a comment.Aug 14 2018, 5:45 PM

Change 450612 merged by jenkins-bot:
[oojs/ui@master] Toolbar: Emit events to let user know if toolbar popups are visible

https://gerrit.wikimedia.org/r/450612

gerritbot added a comment.Aug 14 2018, 6:04 PM

Change 452725 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Deactivate the surface when the toolbar is active

https://gerrit.wikimedia.org/r/452725

gerritbot added a comment.Aug 14 2018, 6:05 PM

Change 450616 abandoned by Esanders:
Mobile: Deactivate the surface when the toolbar is active

Reason:
upstreamed to https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/ /452725/

https://gerrit.wikimedia.org/r/450616

gerritbot added a comment.Aug 15 2018, 12:09 AM

Change 452872 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

gerritbot added a comment.Aug 15 2018, 5:56 PM

Change 452872 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed Patch-For-Review.Aug 15 2018, 7:22 PM
Jdforrester-WMF subscribed.

The OOUI fix landed in MediaWiki 1.32.0-wmf.18.

gerritbot added a comment.Aug 16 2018, 10:52 PM

Change 452725 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Deactivate the surface when the toolbar is active

https://gerrit.wikimedia.org/r/452725

gerritbot added a comment.Aug 16 2018, 11:00 PM

Change 453292 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aac36db2c)

https://gerrit.wikimedia.org/r/453292

gerritbot added a project: Patch-For-Review.Aug 16 2018, 11:00 PM
Jdforrester-WMF assigned this task to Esanders.Aug 16 2018, 11:26 PM
Jdforrester-WMF edited projects, added VisualEditor (Current work); removed VisualEditor.
Jdforrester-WMF moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Aug 17 2018, 10:15 AM

Change 453292 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aac36db2c)

https://gerrit.wikimedia.org/r/453292

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 17 2018, 3:18 PM
Jdforrester-WMF removed a project: Patch-For-Review.Aug 17 2018, 5:24 PM
Ryasmeen added a project: Verified.Aug 20 2018, 7:56 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• Deskana closed this task as Resolved.Aug 21 2018, 9:46 AM
• Deskana subscribed.

Nice!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 21 2018, 9:46 AM
Esanders mentioned this in T202551: Cursor handle can be moved under toolbar on mobile visual editor.Aug 22 2018, 5:58 PM
• Deskana added a project: Editing Q1 2018-19 mobile improvements.Aug 28 2018, 3:57 PM
Esanders added a parent task: T209505: EPIC: Fix selection issues on mobile.Mar 6 2019, 8:04 PM
matmarex mentioned this in T221328: [Epic] Mobile VE usability improvements (FY18-19 Q4).Jun 8 2019, 1:55 PM
JTannerWMF added a project: VisualEditor-Mobile-UsabilityImprovements.Jun 18 2019, 10:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits