Page MenuHomePhabricator

Actually pass username to visualeditor-dialog-media-info-meta-artist
Open, MediumPublic1 Story Points

Description

Per Krenair, modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js can pass 'user' in the iiprop to visualeditor-dialog-media-info-meta-artist for GENDER usage.

Requested at https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Visualeditor-dialog-media-info-artist/en

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterActually get uploader details when querying media info

Event Timeline

Nemo_bis created this task.Aug 19 2015, 7:46 AM
Nemo_bis raised the priority of this task from to Medium.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added projects: VisualEditor, I18n.
Nemo_bis added a subscriber: Nemo_bis.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 7:46 AM
Nemo_bis updated the task description. (Show Details)Aug 19 2015, 7:46 AM
Nemo_bis set Security to None.

Change 232523 had a related patch set uploaded (by Alex Monk):
Actually get uploader details when querying media info

https://gerrit.wikimedia.org/r/232523

I think you misunderstood. What I wrote was:

I think that our code to show the visualeditor-dialog-media-info-artist message is actually broken at the moment due to us not including 'user' in the iiprop list in VE-MW modules/ve-mw/dm/models/ve.dm.MWMediaResourceQueue.js.
We could query user's id in the same way, but not the user's gender, which would be needed to run {{GENDER:}} via jqueryMsg (there would be other problems to solve here as well, such as actually getting an additional parameter to the code which handles the messages - right now we seem to take a single value, and then using the special function to parse it, etc).

This commit will make the message actually get used, but won't add GENDER support.

Krenair claimed this task.Aug 19 2015, 3:55 PM

Change 232523 merged by jenkins-bot:
Actually get uploader details when querying media info

https://gerrit.wikimedia.org/r/232523

Jdforrester-WMF removed Krenair as the assignee of this task.Sep 17 2015, 3:55 PM
Jdforrester-WMF removed a project: Patch-For-Review.
MtDu added a subscriber: MtDu.Jan 29 2016, 4:20 AM

I don't think this message needs GENDER. What do you all think?
Thanks,
MtDu

I don't think this message needs GENDER. What do you all think?

There is probably a need, but not necessarily a solution. Compare T85685.

Amire80 moved this task from Untriaged to Gender on the I18n board.Feb 4 2018, 10:37 AM