Page MenuHomePhabricator
Create Task
Maniphest T109625

ButtonWidget with 'inverted' icon makes all nested icons inverted as well
Closed, ResolvedPublic
Actions

Description

This is mostly affecting things like OO.ui.PopupButtonWidget() that can hold content inside the popup that includes other icons. If the main button has an inverted icon (say, if it's primary) then the inverted class affects all icons inside the popup as well.

Details

SubjectRepoBranchLines +/-
Theme: Add theme classes to $icon and $indicator onlyoojs/uimaster+43 -8
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Aug 19 2015, 8:20 PM
Mooeypoo assigned this task to matmarex.
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a project: OOUI.
Mooeypoo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 8:20 PM
Jdforrester-WMF triaged this task as Medium priority.Aug 19 2015, 8:21 PM
Jdforrester-WMF set Security to None.
gerritbot subscribed.Aug 19 2015, 8:22 PM

Change 231602 had a related patch set uploaded (by Bartosz Dziewoński):
Theme: Add theme classes to $icon and $indicator only

https://gerrit.wikimedia.org/r/231602

gerritbot added a project: Patch-For-Review.Aug 19 2015, 8:22 PM
Jdforrester-WMF closed this task as Resolved.Aug 23 2015, 8:16 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
gerritbot added a comment.Aug 23 2015, 8:21 PM

Change 231602 merged by jenkins-bot:
Theme: Add theme classes to $icon and $indicator only

https://gerrit.wikimedia.org/r/231602

matmarex mentioned this in rGOJUfa063547940c: Theme: Add theme classes to $icon and $indicator only.Aug 23 2015, 8:21 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Aug 26 2015, 1:38 AM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.12.6), WMF-deploy-2015-09-01_(1.26wmf21); removed OOjs-UI-next-release.Aug 26 2015, 3:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL