Page MenuHomePhabricator

mw.Target should not retry badtoken error with full HTML
Closed, ResolvedPublic1 Estimated Story Points

Description

When an error, any error occurs on save, ve.init.mw.Target#tryWithPreparedCacheKey assumes the error must be due to a bad cache key, and retries the request with the full (gzipped) HTML. Only when that fails does it pass the error to its caller. The problem with this is that there are many errors (such as badtoken, or CAPTCHAs, or anything else really) that cannot be remedied by retrying with the full HTML. tryWithPreparedCacheKey should only do this for actual badcachekey errors, not for all errors.

Event Timeline

Catrope created this task.Aug 20 2015, 10:33 PM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added a subscriber: Catrope.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2015, 10:33 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.

Change 232878 had a related patch set uploaded (by Alex Monk):
Don't retry request in tryWithPreparedCacheKey unless the error was badcachekey

https://gerrit.wikimedia.org/r/232878

Change 232878 merged by jenkins-bot:
Don't retry request in tryWithPreparedCacheKey unless the error was badcachekey

https://gerrit.wikimedia.org/r/232878

Jdforrester-WMF closed this task as Resolved.Aug 21 2015, 1:09 AM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.