Page MenuHomePhabricator

DonationInterface normalized message format should match queue format
Closed, InvalidPublic2 Estimated Story Points

Description

This just dawned on me. There are two normalized message formats, and only historical reasons why. We waste a bunch of developer overhead converting back and forth.

DonationInterface\DonationQueue::buildTransactionMessage creates the legacy ActiveMQ pipeline using a snowflake format where fields are given non-normalized keys. For example, the normalized first_name field is called fname in the queue messages.

The new queue code, on the other hand, passes normalized messages.

One approach would be to make wmf_civicrm able to import either the old queue format or regular normalized messages. Then, rewrite DonationQueue to emit normalized messages.

Event Timeline

awight raised the priority of this task from to Medium.
awight updated the task description. (Show Details)
awight added a subscriber: awight.
DStrine set the point value for this task to 4.Jul 29 2016, 8:23 PM
awight changed the point value for this task from 4 to 2.

DonationQueue already outputs normalized messages, and since we're rewriting all the consumers making the change there is trivial.