Page MenuHomePhabricator

"Title::newFromTitle: $text must be a string" from CentralAuthHooks::onSpecialLogAddLogSearchRelations
Closed, ResolvedPublic

Description

Warning: Title::newFromTitle: $text must be a string
from
SpecialLog::execute/Hooks::run/CentralAuthHooks::onSpecialLogAddLogSearchRelations/User::getCanonicalName/Title::newFromText

About 100 hits a day in the T76305 channel. Looks like it's unconditionally passing values from the WebRequest that may be unset or empty.

Event Timeline

Krinkle created this task.Aug 23 2015, 12:59 PM
Krinkle raised the priority of this task from to Medium.
Krinkle updated the task description. (Show Details)
Krinkle added subscribers: Krinkle, Krenair, Reedy.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2015, 12:59 PM
Krinkle raised the priority of this task from Medium to Needs Triage.Aug 23 2015, 1:02 PM
Krinkle set Security to None.
Krinkle removed a subscriber: Krinkle.
demon triaged this task as Medium priority.Aug 24 2015, 3:19 AM
Krenair claimed this task.Aug 24 2015, 1:28 PM

Change 233398 had a related patch set uploaded (by Alex Monk):
Avoid passing non-strings into User::getCanonicalName

https://gerrit.wikimedia.org/r/233398

Change 233398 merged by jenkins-bot:
Avoid passing non-strings into User::getCanonicalName

https://gerrit.wikimedia.org/r/233398

Krenair closed this task as Resolved.Aug 24 2015, 5:47 PM