Maniphest T109973

"Title::newFromTitle: $text must be a string" from CentralAuthHooks::onSpecialLogAddLogSearchRelations
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Aug 23 2015, 12:59 PM

Tags

Referenced Files

None

Subscribers

Description

Warning: Title::newFromTitle: $text must be a string
from
SpecialLog::execute/Hooks::run/CentralAuthHooks::onSpecialLogAddLogSearchRelations/User::getCanonicalName/Title::newFromText

About 100 hits a day in the T76305 channel. Looks like it's unconditionally passing values from the WebRequest that may be unset or empty.

Details

	Subject	Repo	Branch	Lines +/-
	Avoid passing non-strings into User::getCanonicalName	mediawiki/extensions/CentralAuth	master	+6 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	PRODUCTION ERROR	Nikerabbit	T76305 Title::newFromText: $text must be a string
		Resolved		Krenair	T109973 "Title::newFromTitle: $text must be a string" from CentralAuthHooks::onSpecialLogAddLogSearchRelations

Event Timeline

Krinkle created this task.Aug 23 2015, 12:59 PM

Krinkle raised the priority of this task from to Medium.

Krinkle updated the task description. (Show Details)

Krinkle added projects: MediaWiki-General, Wikimedia-production-error.

Krinkle added subscribers: Krinkle, Krenair, Reedy.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2015, 12:59 PM

Krinkle raised the priority of this task from Medium to Needs Triage.Aug 23 2015, 1:02 PM

Krinkle edited projects, added MediaWiki-extensions-CentralAuth; removed MediaWiki-General.

Krinkle set Security to None.

Krinkle unsubscribed.

• demon triaged this task as Medium priority.Aug 24 2015, 3:19 AM

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Aug 24 2015, 3:20 AM

Krenair claimed this task.Aug 24 2015, 1:28 PM

Change 233398 had a related patch set uploaded (by Alex Monk):
Avoid passing non-strings into User::getCanonicalName

https://gerrit.wikimedia.org/r/233398

gerritbot added a project: Patch-For-Review.Aug 24 2015, 1:28 PM

Change 233398 merged by jenkins-bot:
Avoid passing non-strings into User::getCanonicalName

https://gerrit.wikimedia.org/r/233398

Krenair mentioned this in rMEXTb7771b3581e6: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Aug 24 2015, 5:41 PM

Krenair mentioned this in rECAU90eeff0e8057: Avoid passing non-strings into User::getCanonicalName.

Krenair closed this task as Resolved.Aug 24 2015, 5:47 PM

• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 24 2015, 6:00 PM

• demon moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.Aug 24 2015, 8:51 PM

MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.Dec 15 2016, 4:19 PM