Page MenuHomePhabricator
Create Task
Maniphest T110218

Duplicate icons: 'picture' and 'image'
Closed, ResolvedPublic
Actions

Description

We have duplicate icons: 'picture' picture.png (24×24 px, 350 B) and 'image' image-ltr.png (24×24 px, 212 B) (plus several variants of this one). We should probably merge them, keeping the first (original) for Apex theme and the second for MediaWiki theme.

Should be done in tandem with T111044.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[DEPRECATING CHANGE] Duplicate icons: Unify 'picture' and 'image'oojs/uimaster+137 -98
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Aug 25 2015, 5:36 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: good first task, OOUI.
matmarex added subscribers: Aklapper, matmarex.
Jdforrester-WMF subscribed.Aug 25 2015, 5:54 PM

"Easy"? You mean "Breaking change"?

matmarex added a parent task: T55733: Use the same icons to represent the same things (tracking).Sep 1 2015, 1:38 PM
Esanders merged a task: T111043: Merge 'picture' and 'image' icons.Sep 1 2015, 1:43 PM
Esanders subscribed.
Devirk claimed this task.Oct 21 2015, 4:57 PM
Devirk set Security to None.
Devirk subscribed.
Jdforrester-WMF triaged this task as Low priority.Oct 21 2015, 5:20 PM
Jdforrester-WMF removed a project: good first task.
Esanders added a comment.Oct 21 2015, 5:30 PM

We can leave a deprecated alias behind

Esanders updated the task description. (Show Details)Oct 21 2015, 5:30 PM
Esanders mentioned this in T111044: Duplicate icons: 'PhotoGallery' and 'gallery' (in VE).
Devirk mentioned this in T116303: Outreachy Proposal for Implement HTML e-mail support in MediaWiki.Oct 22 2015, 6:35 PM
Devirk added a comment.Oct 23 2015, 2:15 PM

@matmarex can you give me any pointers as to how to get started with the bug? By apex theme do you mean skin:apex and by mediawiki theme do you mean skin:vector?

Esanders added a comment.Oct 23 2015, 2:20 PM

oojsui has two themes: Apex & MediaWIki.

In MediaWiki (the software, not the theme), there are many themes, but the two most popular: Vector & Monobook use MedaiWiki & Apex OOUI themes respectively.

A good place to start is the OOUI demos: https://doc.wikimedia.org/oojs-ui/master/demos/#icons-mediawiki-mixed-ltr

gerritbot subscribed.Nov 11 2015, 7:50 PM

Change 252496 had a related patch set uploaded (by Esanders):
[DEPRECATING CHANGE] Duplicate icons: Unify 'picture' and 'image'

https://gerrit.wikimedia.org/r/252496

gerritbot added a project: Patch-For-Review.Nov 11 2015, 7:50 PM
Jdforrester-WMF closed this task as Resolved.Nov 11 2015, 8:08 PM
Jdforrester-WMF reassigned this task from Devirk to Esanders.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
gerritbot added a comment.Nov 11 2015, 8:13 PM

Change 252496 merged by jenkins-bot:
[DEPRECATING CHANGE] Duplicate icons: Unify 'picture' and 'image'

https://gerrit.wikimedia.org/r/252496

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.13.3), MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)); removed OOjs-UI-next-release.Nov 18 2015, 1:32 AM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Nov 21 2015, 2:30 AM
Lewizho99 subscribed.Mar 7 2016, 9:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits