Page MenuHomePhabricator

Line in languages/Language.php exceeds 9999 characters
Closed, ResolvedPublic

Description

Our custom codesniffer ruleset has a part that goes:

<rule ref="Generic.Files.LineLength">
    <properties>
        <!-- More than 100 will throw a warning ... -->
        <property name="lineLimit" value="100" />
        <!-- ... but we will most probably never throw an error -->
        <property name="absoluteLineLimit" value="9999" />
    </properties>
</rule>

However, a line of length over 10,400 characters was introduced in f5c88ef8e.

I'm not very sure what to do about this. Should there be a // @codingStandardsIgnore comment in that file or should our hard line length limit be updated?

Event Timeline

polybuildr raised the priority of this task from to Needs Triage.
polybuildr updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2015, 8:33 PM
Addshore added a comment.EditedSep 7 2015, 11:14 AM

@polybuildr
I think we should move forward on this by adding a @codingStandardsIgnore tag there!
There is already one for coverage!

Change 236536 had a related patch set uploaded (by Polybuildr):
Add // @codingStandardsIgnore around very very long line in Language.php

https://gerrit.wikimedia.org/r/236536

Addshore closed this task as Resolved.Sep 7 2015, 1:02 PM
Addshore claimed this task.

Marking as resolved, I have +2ed and will be merged shorlty

Change 236536 merged by jenkins-bot:
Add // @codingStandardsIgnore around very very long line in Language.php

https://gerrit.wikimedia.org/r/236536