Maniphest T110244

Surveys get injected into Vector's table of contents
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 25 2015, 9:05 PM

Tags

Referenced Files

	F2363038: Screen Shot 2015-08-25 at 2.05.19 PM.png
	Aug 25 2015, 9:05 PM

Subscribers

Description

Visit https://phabricator.wikimedia.org/T110013 and merge the associated patch
Run the browser tests, ensure they pass.
Visit http://localhost:8888/w/index.php/Quick_survey_test_2?quicksurvey=true&useformat=desktop
Gawk at the horror of

Screen Shot 2015-08-25 at 2.05.19 PM.png (417×902 px, 59 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Don't inject survey into table of contents	mediawiki/extensions/QuickSurveys	dev	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: rEQScbbba014d7a7: Final NoteDb migration updates
rEQS98f9156cb42b: Final NoteDb migration updates
rEQSe645b31a039d: Final NoteDb migration updates
rEQSd3956c657581: Don't inject survey into table of contents

Event Timeline

Jdlrobson created this task.Aug 25 2015, 9:05 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Reading-Web-Sprint-54-28-Days-Later.

Jdlrobson moved this task to To Do on the Reading-Web-Sprint-54-28-Days-Later board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2015, 9:05 PM

Jdlrobson claimed this task.Aug 27 2015, 8:04 PM

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-54-28-Days-Later board.

Change 234420 had a related patch set uploaded (by Jdlrobson):
Don't inject survey into table of contents

https://gerrit.wikimedia.org/r/234420

gerritbot added a project: Patch-For-Review.Aug 27 2015, 8:33 PM

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-54-28-Days-Later board.Aug 27 2015, 8:33 PM

Change 234420 merged by jenkins-bot:
Don't inject survey into table of contents

https://gerrit.wikimedia.org/r/234420

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-54-28-Days-Later board.Aug 28 2015, 10:23 AM

This is a technical task. Also, I tested this locally as part of my review.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-54-28-Days-Later board.Sep 1 2015, 10:09 AM

• Konfused-Kitten mentioned this in rEQSd3956c657581: Don't inject survey into table of contents.Apr 28 2016, 6:23 AM

Jdlrobson mentioned this in rEQSe645b31a039d: Final NoteDb migration updates.Jun 11 2018, 8:31 PM

Jdlrobson mentioned this in rEQS98f9156cb42b: Final NoteDb migration updates.

Jdlrobson mentioned this in rEQScbbba014d7a7: Final NoteDb migration updates.