Maniphest T110272

Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schema
Closed, ResolvedPublic40 Estimated Story Points
Actions

Description

Should log to version 13457736 of the Edit schema, unless we need to make other schema changes beforehand.

Crosswalk from MobileWebEditing to Edit values

editor → editor
token → editingSessionId
action → action
- Start tracking init events
- attempt → ready
- save → saveIntent
- submit → saveAttempt
- success → saveSuccess
- cancel → abort
- error → saveFailure
- switch → abort.switchnochange
  - MF does not allow you to switch if you've made changes.
revId → page.revid
pageId → page.id
namespace → page.ns
userEditCount → user.editCount
errortext → action.saveFailure.message

Things to start logging

action.init.type
action.init.mechanism
action.init.timing
action.ready.timing
action.saveIntent.timing
action.saveAttempt.timing
action.saveSuccess.timing
action.saveFailure.type
action.saveFailure.timing
action.abort.type
action.abort.mechanism
action.abort.timing
mediawiki.version
integration
page.title
user.id
user.class
platform:
- For now, we will make the false assumption that anyone using the mobile interface has platform phone.

Things to stop logging

username
isTestA
mobileMode
section
funnel

Details

Subject	Repo	Branch	Lines +/-
Log VE saveIntent/saveAttempt	mediawiki/extensions/MobileFrontend	master	+24 -0
Hack to stop logging edit events for non-desktop targets	mediawiki/extensions/VisualEditor	master	+2 -1
Revert "Revert "Migrate from SchemaMobileWebEditing to SchemaEdit""	mediawiki/extensions/MobileFrontend	master	+161 -94
Migrate from SchemaMobileWebEditing to SchemaEdit	mediawiki/extensions/MobileFrontend	master	+155 -94
Fix EventLogging schema dependencies	mediawiki/extensions/MobileFrontend	wmf/1.26wmf21	+2 -2
Fix EventLogging schema dependencies	mediawiki/extensions/MobileFrontend	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Krenair	T109525 "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE
Declined	None	T97494 Extremely high amount of errors for anonymous editors when using MobileFrontend's wikitext editor
Resolved	Krenair	T110272 Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schema

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Jdforrester-WMF raised the priority of this task from to High.Aug 26 2015, 1:55 AM

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.

Jdforrester-WMF added subscribers: Jdforrester-WMF, nshahquinn.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2015, 1:55 AM

Jdforrester-WMF added a parent task: T109525: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE.Aug 26 2015, 1:56 AM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Aug 26 2015, 3:43 PM

nshahquinn-wmf updated the task description. (Show Details)Aug 26 2015, 5:18 PM

nshahquinn-wmf set Security to None.

nshahquinn-wmf edited subscribers, added: nshahquinn-wmf; removed: nshahquinn.

token: user.getSessionId()
Looks like this is a random 32 character alphanumeric string stored in localStorage via mw.storage.

Krenair added a project: MobileFrontend.Aug 27 2015, 10:33 PM

errortext → action.saveFailure.type
What goes in the errortext field?

'visualeditor-load-error', an edit API error code, 'unknown', 'http', and possibly some other things?

funnel → action.init.mechanism
do we need to support the specific values from MobileWebEditing? article, ctaSignup, leftNavSignup

article is the default
ctaSignup is old and comes from https://gerrit.wikimedia.org/r/#/c/90450/, seems to have been removed in https://gerrit.wikimedia.org/r/#/c/97872/
Not sure about leftNavSignup.

mobileMode
Do we need this? Should we generalize the destination property so that it could work for a theoretical desktop beta mode? James says we've never used the alpha or beta modes to test editing features.

No. If we need to differentiate between these sorts of things in future we can add a new field for it (certainly should be generalised).

I need to look into some of the existing data for this, and will want to check the actual output when this change arrives in production.

Krenair mentioned this in T110754: Requesting research DB access for Alex Monk.Aug 28 2015, 11:13 PM

mobileMode could be replaced by skin (it's on my todo list) and could have value 'minerva' or 'minerva-beta'.

In T110272#1598647, @Jdlrobson wrote:

mobileMode could be replaced by skin (it's on my todo list) and could have value 'minerva' or 'minerva-beta'.

But we don't record skin either…

isTestA was used for A/B testing. It might come in useful in future. I'm not sure how you plan to run A/B tests in future.
Token was for session tracking for anonymous users so you could see their workflow from A to B.

In T110272#1598655, @Jdlrobson wrote:

isTestA was used for A/B testing. It might come in useful in future. I'm not sure how you plan to run A/B tests in future.
Token was for session tracking for anonymous users so you could see their workflow from A to B.

If we're going to run an A/B test I'd rather we used the existing methods (with a bespoke schema for the test) rather than instrument every edit just on the off-chance that we remember which A/B tests were running at the time.

Re funnel - ctaSignup is very gone (last seen December 2013, a few weeks after the aforementioned commit was merged), but leftNavSignup is still around. Need to look into exactly what that means I guess.

Okay, I've taken another pass as the task description to take into account some of the comments.

switch → abort.switchwith or abort.switchwithout
Have to start distinguishing between the two types of aborts

Once you've made a change, MF doesn't let you switch without saving. It will let you switch if you've done nothing though. This distinction is not relevant.

nshahquinn-wmf updated the task description. (Show Details)Sep 3 2015, 5:43 PM

nshahquinn-wmf updated the task description. (Show Details)

Krenair updated the task description. (Show Details)Sep 3 2015, 5:44 PM

@Krenair, okay, in that case, it will either be abort.switchwith or a value I just added to the schema, abort.switchnochange. Let me know if you find any other problems with my outline.

Krenair updated the task description. (Show Details)Sep 3 2015, 5:45 PM

nshahquinn-wmf updated the task description. (Show Details)Sep 3 2015, 5:49 PM

nshahquinn-wmf updated the task description. (Show Details)Sep 3 2015, 5:52 PM

nshahquinn-wmf updated the task description. (Show Details)Sep 3 2015, 5:54 PM

Jdforrester-WMF renamed this task from Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema to Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schema.Sep 3 2015, 7:44 PM

nshahquinn-wmf added a project: Contributors-Analysis.Sep 3 2015, 8:09 PM

mysql> select count(*) from MobileWebEditing_8599025 where event_action = 'success' and event_errorText is not null;
+----------+
| count(*) |
+----------+
|    17975 |
+----------+
1 row in set (4 min 56.09 sec)

nshahquinn-wmf moved this task from Backlog to Blocked on the Contributors-Analysis board.Sep 3 2015, 11:31 PM

error → saveFailure is not 100% right. It includes loading errors, which does not get logged by VE (maybe log them elsewhere later?)

Change 236239 had a related patch set uploaded (by Alex Monk):
Fix EventLogging schema dependencies

https://gerrit.wikimedia.org/r/236239

gerritbot added a project: Patch-For-Review.Sep 5 2015, 2:28 AM

Change 236244 had a related patch set uploaded (by Alex Monk):
[WIP] Migrate from SchemaMobileWebEditing to SchemaEdit

https://gerrit.wikimedia.org/r/236244

(Does not include timing fields)

Change 236239 merged by jenkins-bot:
Fix EventLogging schema dependencies

https://gerrit.wikimedia.org/r/236239

Diffusion mentioned this in rMEXT619ec2bcc831: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 7 2015, 3:29 PM

Krenair mentioned this in rEMFR17238d9ece59: Fix EventLogging schema dependencies.Sep 7 2015, 3:29 PM

Change 236558 had a related patch set uploaded (by Alex Monk):
Fix EventLogging schema dependencies

https://gerrit.wikimedia.org/r/236558

Change 236558 merged by jenkins-bot:
Fix EventLogging schema dependencies

https://gerrit.wikimedia.org/r/236558

Krenair mentioned this in rMW2a677a9e2abf: Updated mediawiki/core Project: mediawiki/extensions/MobileFrontend….Sep 7 2015, 3:38 PM

Jdforrester-WMF mentioned this in rEMFR980a2bae358e: Fix EventLogging schema dependencies.Sep 7 2015, 3:38 PM

ReleaseTaggerBot added projects: WMF-deploy-2015-09-01_(1.26wmf21), WMF-deploy-2015-09-08_(1.26wmf22).Sep 7 2015, 4:00 PM

Krenair mentioned this in T111894: MobileFrontend VisualEditor edit conflict detection does not work.Sep 9 2015, 3:09 AM

Krenair mentioned this in rEVED2fcf6b7ce704: Load visualeditor-saveerror-titleblacklist and fancycaptcha-reload-text for….Sep 10 2015, 5:59 PM

Change 236244 merged by jenkins-bot:
Migrate from SchemaMobileWebEditing to SchemaEdit

https://gerrit.wikimedia.org/r/236244

Krenair mentioned this in rEMFRc0a8d3071e86: Migrate from SchemaMobileWebEditing to SchemaEdit.Sep 10 2015, 11:50 PM

Diffusion mentioned this in rMEXTc5c5991c9965: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 10 2015, 11:50 PM

ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 11 2015, 12:00 AM

Jdforrester-WMF closed this task as Resolved.Sep 11 2015, 12:06 AM

Jdforrester-WMF removed projects: WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-01_(1.26wmf21), Patch-For-Review.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF reopened this task as Open.Sep 16 2015, 3:50 PM

Jdforrester-WMF removed a project: WMF-deploy-2015-09-15_(1.26wmf23).

Jdforrester-WMF edited a custom field.

Change 237738 had a related patch set uploaded (by Jforrester):
Revert "Revert "Migrate from SchemaMobileWebEditing to SchemaEdit""

https://gerrit.wikimedia.org/r/237738

gerritbot added a project: Patch-For-Review.Sep 16 2015, 3:51 PM

Jdforrester-WMF mentioned this in T97494: Extremely high amount of errors for anonymous editors when using MobileFrontend's wikitext editor.Sep 16 2015, 3:52 PM

Jdforrester-WMF added a parent task: T97494: Extremely high amount of errors for anonymous editors when using MobileFrontend's wikitext editor.

Change 237738 merged by jenkins-bot:
Revert "Revert "Migrate from SchemaMobileWebEditing to SchemaEdit""

https://gerrit.wikimedia.org/r/237738

Jdforrester-WMF mentioned this in rEMFRee179678f72b: Revert "Revert "Migrate from SchemaMobileWebEditing to SchemaEdit"".Sep 16 2015, 4:06 PM

Diffusion mentioned this in rMEXTb363fd509f4e: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 16 2015, 4:06 PM

ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 16 2015, 5:00 PM

Looks like we're sending two saveSuccess events for VE in MF

Reverting again: https://gerrit.wikimedia.org/r/#/c/239526/

I chatted to @Krenair and it seems like this has stalled and it's not clear if you want to revert it and why. Could you let me know what's happening here and update the commit message / this bug appropriately? Thanks.

Jay8g subscribed.Oct 1 2015, 4:47 AM

Change 242952 had a related patch set uploaded (by Alex Monk):
Hack to stop logging edit events for non-desktop targets

https://gerrit.wikimedia.org/r/242952

Change 243044 had a related patch set uploaded (by Alex Monk):
Log VE saveIntent/saveAttempt

https://gerrit.wikimedia.org/r/243044

Jdforrester-WMF closed this task as Resolved.Oct 2 2015, 12:03 AM

Change 243044 merged by jenkins-bot:
Log VE saveIntent/saveAttempt

https://gerrit.wikimedia.org/r/243044

Krenair mentioned this in rMEXT0c0269395da5: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Oct 2 2015, 12:08 AM

Change 242952 merged by jenkins-bot:
Hack to stop logging edit events for non-desktop targets

https://gerrit.wikimedia.org/r/242952

Krenair mentioned this in rEVEDa46b7a819eaa: Hack to stop logging edit events for non-desktop targets.Oct 2 2015, 12:10 AM

Krenair mentioned this in rEMFR5455863c73c1: Log VE saveIntent/saveAttempt.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 2 2015, 1:01 AM

nshahquinn-wmf mentioned this in T138894: Create an expanded editor-month data warehouse.Jun 29 2016, 6:25 PM

nshahquinn-wmf raised the priority of this task from High to Needs Triage.Mar 29 2018, 9:05 AM

nshahquinn-wmf moved this task from Blocked to Radar on the Contributors-Analysis board.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 29 2018, 9:05 AM

nshahquinn-wmf triaged this task as High priority.Mar 30 2018, 10:21 AM

nshahquinn-wmf moved this task from Radar to Done on the Contributors-Analysis board.

nshahquinn-wmf moved this task from Done to Radar on the Contributors-Analysis board.

Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schemaClosed, ResolvedPublic40 Estimated Story PointsActions