Page MenuHomePhabricator
Create Task
Maniphest T110281

Rewrite email management to use AuthManager
Closed, ResolvedPublic
Actions

Description

  • Special:ChangeEmail

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• DeskanaT75616 Tracking: API/backend issues blocking Wikipedia app development
 ResolvedAnomieT32788 Allow triggering of user password reset email via the API
 ResolvedAnomieT48179 Allow a challenge stage during authentication
 ResolvedNoneT5709 Refactoring to make external authentication and identity systems easier
 ResolvedTgrT43201 UserLoadFromSession considered evil
 ResolvedAnomieT67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
 OpenFeatureNoneT55156 Provide option to force a login session to end within a certain time
 ResolvedNoneT89459 Modernize MediaWiki authentication system (AuthManager)
 ResolvedTgrT110279 Rewrite core classes which need to be clients of AuthManager
 ResolvedTgrT110281 Rewrite email management to use AuthManager
 ResolvedAnomieT91699 Create AuthManager framework and core classes
 ResolvedJoeT97675 Custom session handler corrupted by session_destroy, "Failed to initialize storage module"
 ResolvedJoeT106483 Create new HHVM package for HHVM 3.6.5 + patches
 ResolvedhasharT106699 Upgrade HHVM related packages on Trusty Jenkins slaves
 Resolvedbd808T95864 Mocking abstract objects fails on HHVM
 ResolvedAnomieT110274 Fix PHPUnit version incompatibility between AuthManager and Jenkins
 ResolvedKrinkleT99982 Upgrade PHPUnit to 4.0+
 ResolvedNoneT90303 Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches
 ResolvedJanZerebeckiT106433 replace inline perl in builder wd-mw-composer-merged-install with a proper script
 ResolvedKrinkleT112895 Support installing composer require-dev packages together with mediawiki/vendor
 ResolvedTgrT110628 Improve AuthManager documentation

Event Timeline

Tgr created this task.Aug 26 2015, 6:18 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: MediaWiki-Core-AuthManager, Reading-Infrastructure-Team-Old (Don't use), MediaWiki-Email.
Tgr subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2015, 6:18 AM
Tgr added a comment.Aug 26 2015, 6:18 AM

This would also be a good time to refactor the email change business logic into a non-UI-related class and expose it as an API.

Tgr added a subtask: T91699: Create AuthManager framework and core classes.Aug 26 2015, 6:19 AM
Tgr added a parent task: T110279: Rewrite core classes which need to be clients of AuthManager.
bd808 moved this task from Backlog to AuthManager Backlog on the MediaWiki-Core-AuthManager board.Aug 26 2015, 5:33 PM
Anomie closed subtask T91699: Create AuthManager framework and core classes as Resolved.May 25 2016, 6:51 PM
Liuxinyu970226 subscribed.Jan 26 2017, 9:41 AM
• NHarateh_WMF added a project: Product-Infrastructure-Team-Backlog-Deprecated.Apr 25 2017, 12:43 PM
• NHarateh_WMF moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.Apr 25 2017, 12:46 PM
Tgr removed projects: Product-Infrastructure-Team-Backlog-Deprecated, Reading-Infrastructure-Team-Old (Don't use).May 2 2017, 4:58 PM
Krinkle subscribed.Nov 29 2017, 2:27 AM

The part actually in SpecialChangeEmail was done as part of rMW3617c982c9db: Use AuthManager on special pages

However, it seems the code in User::setEmail has not significantly changed. Is this task done, or should that method be changed in some way involve AuthManager?

Tgr closed this task as Resolved.Nov 29 2017, 5:16 AM
Tgr claimed this task.

I think I just forgot to close it. ChangeEmail was updated and PasswordReset was rewritten, and those were the only email management functions really related to authentication.

Liuxinyu970226 unsubscribed.Nov 30 2017, 11:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits