Page MenuHomePhabricator

Summary of campaign settings changes is not logged in CentralNotice logs when modified using Special:CentralNotice main page table
Closed, ResolvedPublic

Description

I've been cleaning the Special:CentralNotice page, deactivating and archiving expired campaigns. I entered a summary in the summary field, at the bottom of the table, however that reason isn't logged in the log. Thanks.

Event Timeline

MarcoAurelio raised the priority of this task from to Needs Triage.
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio added a subscriber: MarcoAurelio.
atgo renamed this task from Summary of campaing settings changes not logged in CentralNotice logs to Summary of campaign settings changes not logged in CentralNotice logs.Aug 26 2015, 6:12 PM
atgo triaged this task as Medium priority.
atgo set Security to None.

Ah, it's not working when you modify it from the main table. It works when you modify from specific campaign pages. The last two modifications by me was done using the main page.

Glaisher renamed this task from Summary of campaign settings changes not logged in CentralNotice logs to Summary of campaign settings changes is not logged in CentralNotice logs when modified using Special:CentralNotice main page table.Aug 30 2015, 5:09 AM

We seem to be having lots of undefined variables in CentralNotice files. :-/

Change 234834 had a related patch set uploaded (by Glaisher):
Special:CentralNotice: always log the summary change if it was in the request

https://gerrit.wikimedia.org/r/234834

awight added a subscriber: awight.

Love to see these glitches shut down!

Change 234834 merged by jenkins-bot:
Special:CentralNotice: always log the summary change if it was in the request

https://gerrit.wikimedia.org/r/234834

Reopening, I just experienced this bug when making changes at 12 November 2015 19:09 UTC

This should be solved now with the changes in review for T128869. Just bringing this task into the current sprint, since we could probably fully confirm while we review and test that one. Thx!!

The code that handles campaign changes from Special:CentralNotice just got a major overhaul. The summary field appears to work. Could you maybe see if it works for you, and if not, help us discover more details? Thanks much!! :)

Pcoombe added a subscriber: Pcoombe.

This seems to work consistently now.