The way EntityChange is implemented is tricky to use and maintain. The deopendency on ORMRow seems to add a lot of complexity. The long inheritance chain ORMRow -> ChangeRow -> DiffChange -> EntityChange seems unneccessary, since all the changes wikibase needs to propagate are changes to entities.
A rewrite should result in a reduction in the amount and complexity of code.
We should also use this opportunity to move Change-related code into DataModelServices.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/Wikibase | master | +67 -17 | Make ChangeRow not inherit from ORMRow |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T31145 Core features that shouldn't be in core (tracking) | |||
| Resolved | Reedy | T114538 ExtractORM from MediaWiki core and move to the EducationProgram extension | |||
| Open | None | T108944 [Epic] Improve change dispatching | |||
| Resolved | hoo | T110343 [Task] Rewrite EntityChange, drop dependency on ORMRow and ORMTable | |||
| Resolved | hoo | T111056 [Task] Replace ChangesTable orm abstraction with ChangeStore and ChangeLookup |
This is not yet fully done: We yet dropped the dependency on ORMTable, but not yet the one on ORMRow.
There's not much left, though.
Change 245949 had a related patch set uploaded (by Hoo man):
Make ChangeRow not inherit from ORMRow