Page MenuHomePhabricator

Fix cohesion/CRP issue in Wikibase DataModel Services
Closed, ResolvedPublic

Description

Wikibase DataModel Serialization and Wikibase Internal Serialization currently depend on Wikibase DataModel Services due to their usage of EntityIdParser. They are thus needlessly affected by changes to anything else in this component.

I think moving EntityIdParser out of DataModel was a mistake and should be reverted to improve the cohesion and decrease the coupling of the involved components.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore set Security to None.

Should be done before 2.0 release

This PR removes the only dependency that is not a EntityIdParser: https://github.com/wmde/WikibaseDataModelSerialization/pull/165

This comment was removed by Addshore.
Addshore claimed this task.

Patches merged, releases pending, adoption by wikibase pending