Page MenuHomePhabricator

Fix cohesion/CRP issue in Wikibase DataModel Services
Closed, ResolvedPublic

Description

Wikibase DataModel Serialization and Wikibase Internal Serialization currently depend on Wikibase DataModel Services due to their usage of EntityIdParser. They are thus needlessly affected by changes to anything else in this component.

I think moving EntityIdParser out of DataModel was a mistake and should be reverted to improve the cohesion and decrease the coupling of the involved components.

Event Timeline

JeroenDeDauw raised the priority of this task from to Needs Triage.
JeroenDeDauw updated the task description. (Show Details)
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 26 2015, 2:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore triaged this task as High priority.Aug 26 2015, 3:09 PM
Addshore set Security to None.

Should be done before 2.0 release

JeroenDeDauw added a comment.EditedAug 26 2015, 3:09 PM

This PR removes the only dependency that is not a EntityIdParser: https://github.com/wmde/WikibaseDataModelSerialization/pull/165

This comment was removed by Addshore.
Addshore closed this task as Resolved.Aug 26 2015, 7:31 PM
Addshore claimed this task.

Patches merged, releases pending, adoption by wikibase pending

Bene moved this task from Backlog to Done on the Wikidata-Sprint-2015-08-18 board.
Bene moved this task from Done to Doing on the Wikidata-Sprint-2015-08-18 board.