Page MenuHomePhabricator
Create Task
Maniphest T110375

[Bug] Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in EditEntity.php on line 562
Closed, ResolvedPublic
Actions

Description

Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/EditEntity.php on line 562

Details

SubjectRepoBranchLines +/-
Add missing type check to ClaimsChangeOpDeserializermediawiki/extensions/Wikibasemaster+18 -7
Customize query in gerrit

Event Timeline

aude created this task.Aug 26 2015, 6:45 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added projects: MediaWiki-extensions-WikibaseRepository, Wikidata.
aude added subscribers: aude, Aklapper.

note this is in wmf19, so not new for this week's deployment but could have been new from last week

aude added a comment.Aug 26 2015, 6:47 PM

found a stack trace...

ErrorException from line 562 of /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/EditEntity.php: PHP Error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given {"exception":"[Exception ErrorException] (/srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/EditEntity.php:562) PHP Error: Argument 1 passed to Wikibase\\Repo\\Api\\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given\n[stacktrace]\n#0 /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/EditEntity.php(562): MWExceptionHandler::handleError(integer, string, string, integer)\n#1 /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/EditEntity.php(504): Wikibase\\Repo\\Api\\EditEntity->getRemoveStatementChangeOps(string)\n#2 /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/EditEntity.php(295): Wikibase\\Repo\\Api\\EditEntity->getClaimsChangeOps(array)\n#3 /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/EditEntity.php(235): Wikibase\\Repo\\Api\\EditEntity->getChangeOps(array, Wikibase\\DataModel\\Entity\\Item)\n#4 /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/ModifyEntity.php(439): Wikibase\\Repo\\Api\\EditEntity->modifyEntity(Wikibase\\DataModel\\Entity\\Item, array, integer)\n#5 /srv/mediawiki/php-1.26wmf19/includes/api/ApiMain.php(1093): Wikibase\\Repo\\Api\\ModifyEntity->execute()\n#6 /srv/mediawiki/php-1.26wmf19/includes/api/ApiMain.php(432): ApiMain->executeAction()\n#7 /srv/mediawiki/php-1.26wmf19/includes/api/ApiMain.php(405): ApiMain->executeActionWithErrorHandling()\n#8 /srv/mediawiki/php-1.26wmf19/api.php(88): ApiMain->execute()\n#9 /srv/mediawiki/w/api.php(3): include(string)\n#10 {main}\n"}

aude added a project: Wikimedia-production-error.Aug 26 2015, 10:09 PM
aude set Security to None.
• demon triaged this task as Medium priority.Sep 1 2015, 5:36 PM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.
• demon subscribed.
Ricordisamoa subscribed.Sep 4 2015, 5:45 PM

Seems easy to reproduce by passing {"claims":{"key":"value"}} as data to wbeditentity.

aude renamed this task from Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in EditEntity.php on line 562 to [Bug] Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in EditEntity.php on line 562 .Sep 10 2015, 11:34 AM
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.Sep 10 2015, 7:04 PM
• mmodell subscribed.Nov 4 2015, 10:15 PM

I'm seeing this in 1.27.0-wmf.5:

Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in /srv/mediawiki/php-1.27.0-wmf.5/extensions/Wikidata/extensions/Wikibase/r
epo/includes/api/EditEntity.php on line 562
matej_suchanek renamed this task from [Bug] Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in EditEntity.php on line 562 to [Bug] Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in EditEntity.php on line 562.Apr 15 2017, 4:20 PM
matej_suchanek added a project: TestMe.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 15 2017, 4:20 PM
gerritbot subscribed.Apr 20 2017, 12:06 PM

Change 349204 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Add missing type check to ClaimsChangeOpDeserializer

https://gerrit.wikimedia.org/r/349204

gerritbot added a project: Patch-For-Review.Apr 20 2017, 12:06 PM
thiemowmde claimed this task.Apr 20 2017, 12:15 PM
thiemowmde subscribed.
gerritbot added a comment.Apr 20 2017, 12:38 PM

Change 349204 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add missing type check to ClaimsChangeOpDeserializer

https://gerrit.wikimedia.org/r/349204

• AnotherLadsgroup closed this task as Resolved.Jul 15 2017, 8:03 AM
• AnotherLadsgroup removed a project: Patch-For-Review.
• AnotherLadsgroup subscribed.

Works just fine, the patch @thiemowmde made fixed it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL