Page MenuHomePhabricator

login.py doesnt recognise * in config.usernames
Closed, ResolvedPublic

Description

With an entry like follows in user-config.py

usernames['wikipedia']['*'] = 'JVbot-test'

login.py emits a error

$ python pwb.py login -all
Logged in on wikipedia:test as JVbot-test.
*.wikipedia is not a valid site, please remove it from your config

Event Timeline

jayvdb raised the priority of this task from to Needs Triage.
jayvdb updated the task description. (Show Details)
jayvdb added projects: Pywikibot, Pywikibot-Login.
jayvdb subscribed.
Dalba subscribed.

Currently I get:

$ python pwb.py login -all
*.wikipedia is not a valid site, please remove it from your config
Traceback (most recent call last):
  File "pwb.py", line 263, in <module>
    if not main():
  File "pwb.py", line 257, in main
    run_python_file(filename, [filename] + args, argvu, file_package)
  File "pwb.py", line 121, in run_python_file
    main_mod.__dict__)
  File ".\scripts\login.py", line 193, in <module>
    main()
  File ".\scripts\login.py", line 166, in main
    for familyName in namedict:
RuntimeError: dictionary changed size during iteration
<class 'RuntimeError'>
CRITICAL: Closing network session.

Change 339806 had a related patch set uploaded (by Dalba):
login.py: Recognise * in config.usernames

https://gerrit.wikimedia.org/r/339806

Change 339806 abandoned by Dalba:
login.py: Recognise * in config.usernames

Reason:
May take a long time to login to all sites. Maybe we can take advantage of CentralAuth. Needs further investigation.

https://gerrit.wikimedia.org/r/339806

Dalba removed Dalba as the assignee of this task.Feb 25 2017, 4:17 AM
Dalba removed a project: Patch-For-Review.
Framawiki subscribed.

It can really be practical.

Xqt changed the task status from Open to In Progress.Jan 19 2025, 10:39 AM
Xqt claimed this task.
Xqt added subscribers: Xqt, Beta16.

Change #1112370 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] login.py: Recognise * in config.usernames

https://gerrit.wikimedia.org/r/1112370

Change #1112370 merged by jenkins-bot:

[pywikibot/core@master] login.py: Recognise * in config.usernames

https://gerrit.wikimedia.org/r/1112370