vendor/zordius - file permissions trigger debian lintian warnings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	wpmirrordev
	Aug 26 2015, 10:49 PM

Description

0. Context

DEB packages of mediawiki and many of its extensions, are prepared as part of the WP-MIRROR project.
See https://www.mediawiki.org/wiki/Wp-mirror.

Lintian

During the build process, lintian performs a great number of sanity checks, including seeing if each file has file permissions appropriate to its file type.

When lintian sees a non-executable file with 755 permissions, rather than 644, lintian will throw a warning like:

wp-mirror-mediawiki: executable-not-elf-or-script usr/share/wp-mirror-mediawiki/vendor/zordius/lightncandy/tests/example_helpers.php

Files which should have permissions set to 644

vendor/zordius/lightncandy/tests/example_helpers.php

Technical details

DEB standards version: 3.9.6
GIT branch: master

Details

	Subject	Repo	Branch	Lines +/-
	Permission fix	mediawiki/core	master	+220 K -1
	Permission file problem fixed	mediawiki/core	master	+0 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Reedy	T110418 vendor/zordius - file permissions trigger debian lintian warnings
		Resolved		Reedy	T121947 Upgrade zordius/lightncandy from 0.23 to 1.x

Event Timeline

wpmirrordev created this task.Aug 26 2015, 10:49 PM

wpmirrordev raised the priority of this task from to Medium.

wpmirrordev updated the task description. (Show Details)

wpmirrordev added projects: MediaWiki-Vendor, good first task.

wpmirrordev subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2015, 10:49 PM

xSavitar claimed this task.Sep 23 2015, 2:36 PM

xSavitar set Security to None.

Change 240381 had a related patch set uploaded (by D3r1ck01):
Permission file problem fixed

https://gerrit.wikimedia.org/r/240381

gerritbot added a project: Patch-For-Review.Sep 23 2015, 4:28 PM

Change 240381 abandoned by D3r1ck01:
Permission file problem fixed

Reason:
nothing to be done.

https://gerrit.wikimedia.org/r/240381

Change 240381 restored by D3r1ck01:
Permission file problem fixed

Reason:
I need to review it.

https://gerrit.wikimedia.org/r/240381

Change 240420 had a related patch set uploaded (by D3r1ck01):
Permission fix

https://gerrit.wikimedia.org/r/240420

Change 240381 abandoned by D3r1ck01:
Permission file problem fixed

Reason:
deleted.

https://gerrit.wikimedia.org/r/240381

I think a better solution to this problem is going to be to provide a patch to upstream that removes these example scripts from the files that get installed. An example of us doing this for another package we deploy is: https://github.com/nmred/kafka-php/commit/405a9b655472acca1c7f1b6ba43cc26600e05e1e

Change 240420 abandoned by D3r1ck01:
Permission fix

Reason:
not to work on again.

https://gerrit.wikimedia.org/r/240420

xSavitar removed xSavitar as the assignee of this task.Sep 23 2015, 6:48 PM