On https://en.m.wikivoyage.org/wiki/London
London banner is collapsible.
The section headings, however are not as the h1 is inside #bodyContent
MobileFrontend should be updated to be cleverer at how it decides what to format and collapse on.
Unfortunately, this means going into MobileFormatter...
Easiest thing to do I think is to change <(h[1-6])> and <(h[2-6])> turn off support for section collapsing in MobileFormatter.php on the h1 level. It's a rare edgecase any how.
If someone can fix I'll get this SWAT deployed tomorrow.
Hot fixed in production: https://en.wikivoyage.org/w/index.php?title=MediaWiki%3AMobile.js&type=revision&diff=2845051&oldid=2467773
@Florian any ideas on the best way forward here?
Removing <h1> from list of tags defined in MobileFormatter::findTopHeading() would solve the problem. Would that however lead to side effects?
Hi together,
We should make sure, that this doesn't break anything. The list of h1s was added to fix both, T62478: Table of contents looks weird when only one lead section and T62479: Can't edit subsequent sections when a section is commented out. Isn't this needed anymore? Doesn't this has any side effects?
Btw.: Why does Wikivoyage (at least on the London page) doesn't have edit links for each section? And why is the ToC appended to the page-secondary box? :/
We should probably be more restrictive when taking a possible amount of h-tags in the DOM. Let me think about that :) If this doesn't work or is too hacky, +1 to your suggestion @Jdlrobson.
Change 234307 had a related patch set uploaded (by Florianschmidtwelzow):
Hotfix: Make the list of possible top headings configurable
Change 234314 had a related patch set uploaded (by Florianschmidtwelzow):
Be more restrictive when selecting the tag for the first heading
Change 234331 had a related patch set uploaded (by Jdlrobson):
Make the list of possible top headings configurable
Change 234307 merged by jenkins-bot:
Make the list of possible top headings configurable
Change 234331 merged by jenkins-bot:
Make the list of possible top headings configurable
Change 234330 had a related patch set uploaded (by Alex Monk):
Disable section collapsing on h1s in Wikivoyage
Change 234314 abandoned by Florianschmidtwelzow:
Be more restrictive when selecting the tag for the first heading
Reason:
Ok, that's an argument.