Page MenuHomePhabricator

Copying a template-defined reference should be blocked because VE has no HTML to copy (causing Parsoid to throw a 500 error)
Closed, ResolvedPublic1 Story Points

Description

See https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=678051254#parsoidserver-http:_HTTP_500

I found an entry for that error in Kibana:

extension src id undefined points to non-existent element for:  <span typeof="mw:Extension/ref" data-mw="{&quot;name&quot;:&quot;ref&quot;,&quot;attrs&quot;:{&quot;name&quot;:&quot;Floyd-2008&quot;},&quot;body&quot;:{&quot;html&quot;:&quot;&quot;}}" about="#mwt13" class="reference" id="cite_ref-Floyd-2008_6-0" rel="dc:references" data-parsoid-diff="{&quot;id&quot;:498826,&quot;diff&quot;:[&quot;inserted&quot;]}"><sup href="#cite_note-Floyd-2008-6">[1]</sup></span>

There are 37 such <ref> related error entries in the last 24 hours. CX used to have bugs with this and I assumed these were all CX, but I now see that this could also be from VE edits.

Event Timeline

ssastry created this task.Aug 27 2015, 3:21 AM
ssastry updated the task description. (Show Details)
ssastry raised the priority of this task from to Needs Triage.
ssastry added a project: VisualEditor.
ssastry added a subscriber: ssastry.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2015, 3:21 AM
Jdforrester-WMF renamed this task from Bug in copy-pasting of <ref>s in VE? to Copying a template-defined reference should be blocked because VE has no HTML to copy (causing Parsoid to throw a 500 error).Aug 27 2015, 6:11 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Change 234408 had a related patch set uploaded (by Esanders):
Don't allow paste of template-defined ref in a different VE doc

https://gerrit.wikimedia.org/r/234408

Change 234408 merged by jenkins-bot:
MWReferenceNode: Don't allow cross-VE paste of template-defined ref

https://gerrit.wikimedia.org/r/234408

Jdforrester-WMF closed this task as Resolved.Aug 31 2015, 10:03 PM
Jdforrester-WMF removed a project: Patch-For-Review.