Page MenuHomePhabricator

Modify MediaWiki:Globalcssjs-warning-js and MediaWiki:Globalcssjs-warning-css
Closed, ResolvedPublic

Description

@Avicennasis suggested here and there to update the message for global css and js files. I feel that the suggested changes are good that maybe the message itself could be modified. It's also good first task. Best regards.

See also T108516: Add page indicator with help link to [[Special:MyPage/global.js]]

Event Timeline

MarcoAurelio raised the priority of this task from to Needs Triage.
MarcoAurelio updated the task description. (Show Details)

Don't know how to upload it to gerrit yet, but this is what it should be modified at mediawiki/extensions/GlobalCssJs/i18n/central/en.json

{P1935}

You could also try to submit a patch to Gerrit yourself. :-) See https://www.mediawiki.org/wiki/Gerrit/Getting_started and https://www.mediawiki.org/wiki/Gerrit/Tutorial

It might be difficult at first but will be easy once you learn the basics. If you get stuck somewhere, you can always drop by #wikimedia-dev or MediaWiki-General and ask for help there.

Don't know how to upload it to gerrit yet, but this is what it should be modified at mediawiki/extensions/GlobalCssJs/i18n/central/en.json

This should be in WikimediaMessages extension, not GlobalCssJs as the proposed messages are specific to Wikimedia wikis.

@Glaisher Thanks. I'm a bit short of time now to fully understand everything on the pages you gave to me so I'd preferr if somebody else could work on the proper patch for this. I supose I'll have more good first task bugs to work with once I get started with this :-)

Thanks for taking a look at the code! You are very welcome to use developer access to submit this as a Git branch directly into Gerrit. If you don't want to set up Git/Gerrit, you can also try the Gerrit Patch Uploader.

I just looked at the proposed changes. We can just simply add the link to the help page and omit the Wikimedia-specific part. That way we won't have to manage two messages for this.

I'm willing to take a shot at this one.

Thanks for taking a look at the code! You are very welcome to use developer access to submit this as a Git branch directly into Gerrit. If you don't want to set up Git/Gerrit, you can also try the Gerrit Patch Uploader.

But I might need Git to create the diff of the patch, right?

Yes you'll need to check out ("clone") the code repository from Git to edit the code but if you need any help just ask :)

Change 234433 had a related patch set uploaded (by Gerrit Patch Uploader):
T110516 Modify MediaWiki:Globalcssjs-warning-js and MediaWiki:Globalcssjs-warning-css

https://gerrit.wikimedia.org/r/234433

Change 234433 merged by jenkins-bot:
Link to docs in MediaWiki:Globalcssjs-warning-js and MediaWiki:Globalcssjs-warning-css, per T110516

https://gerrit.wikimedia.org/r/234433

MarcoAurelio added a subscriber: Legoktm.

Since https://gerrit.wikimedia.org/r/#/c/234433 is now merged, I think this one can be closed. @Legoktm please have a look though, this is my first commit.

Change 234524 had a related patch set uploaded (by MarcoAurelio):
Followup on T110516

https://gerrit.wikimedia.org/r/234524