template.py does not recognize nested templates
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Meno25
	Aug 27 2015, 2:21 PM

Description

When using template.py (compat) on Wikimedia Labs to remove a template from a list of articles using the command:

python template.py "Persondata" -remove

I noticed that the template (ar:Template:Persondata) gets removed only partially if one of the template parameters is another template.
Examples:

Page 1 (Here the parameter "DATE OF BIRTH" contains this template)
Page 2 (The same parameter contains the same template)

I used the compat version of template.py. Didn't test the core version of the script.

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Enable nested templates with MultiTemplateMatchBuilder	pywikibot/core	master	+8 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T229723 Insufficient wikitext regex parser functions in textlib (tracking)
Resolved	Xqt	T110529 template.py does not recognize nested templates
Open	None	T106765 migrate textlib parser functionality to mwparserfromhell
Resolved	Xqt	T106763 Mandatory dependency on mwparserfromhell
Resolved	• Ladsgroup	T88069 Add pure python mwparserfromhell to nightlies
Resolved	Xqt	T71384 extract_templates_and_params parser bugs loading w:en:Main_Page with mwparserfromhell
Open	None	T279005 Use textlib.extract_templates_and_param or Page.templatesWithParams in commons_information.py

Event Timeline

Meno25 created this task.Aug 27 2015, 2:21 PM

Meno25 raised the priority of this task from to Needs Triage.

Meno25 updated the task description. (Show Details)

Meno25 added a project: Pywikibot-compat.

Meno25 subscribed.

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptAug 27 2015, 2:21 PM

Won't fix in compat. Try core and file a new bug when it's failing.

Reopened due to the bug also exists in core. Refer https://en.wikipedia.org/wiki/User_talk:Xqt#T110529

Xqt removed a project: Pywikibot-tests.Apr 8 2016, 6:45 AM

Looks like the textlib._MultiTemplateMatchBuilder does not recognize nested templates.

Xqt renamed this task from template.py (compat) removes template partially if one of template parameters contains another template to template.py does not recognize nested templates.Apr 8 2016, 7:47 AM

Dalba subscribed.Apr 11 2016, 11:45 PM

Dalba added a subtask: T106765: migrate textlib parser functionality to mwparserfromhell.Apr 11 2016, 11:51 PM

Correct. There are three TODOs in that cls iirc.

binbot subscribed.Aug 26 2016, 7:18 PM

Xqt removed a project: Pywikibot-compat.Jun 30 2017, 12:28 PM

Xqt added a parent task: T229723: Insufficient wikitext regex parser functions in textlib (tracking).Aug 3 2019, 9:57 AM

Restricted Application added subscribers: Liuxinyu970226, alaa. · View Herald TranscriptAug 3 2019, 9:57 AM

Xqt merged a task: T303811: template.py too greedy when removing template.Mar 15 2022, 5:16 PM

Xqt added a subscriber: jhsoby.

Change 770956 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Enable nested templates with MultiTemplateMatchBuilder

https://gerrit.wikimedia.org/r/770956