Page MenuHomePhabricator
Create Task
Maniphest T110542

Investigate whether CentralAuth still needs the 'rememberpassword' setting
Closed, ResolvedPublic
Actions

Description

It was removed from core in rMW74756a24091d: Removed 'Remember my login' preference, and it came up the CentralAuth is still relying on it for something in the CR of https://gerrit.wikimedia.org/r/#/c/234158/

Determine whether CA still needs it and why.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove uses of removed 'rememberpassword' preferencemediawiki/extensions/CentralAuthmaster+1 -25
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Aug 27 2015, 3:57 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: MediaWiki-extensions-CentralAuth, Performance Issue, Technical-Debt.
Legoktm added subscribers: Legoktm, PleaseStand, • Gilles, aaron.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2015, 3:57 PM
Danny_B moved this task from Unsorted to Needs research on the Technical-Debt board.Jan 23 2016, 9:57 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 23 2016, 9:57 AM
valerio.bozzolan subscribed.Jan 1 2021, 10:08 PM
Urbanecm_WMF subscribed.May 6 2024, 10:44 PM

A couple of years later...does it?

gerritbot added a comment.Jul 30 2024, 2:29 AM

Change #1057997 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] Remove uses of removed 'rememberpassword' preference

https://gerrit.wikimedia.org/r/1057997

gerritbot added a project: Patch-For-Review.Jul 30 2024, 2:29 AM
matmarex claimed this task.Jul 30 2024, 2:29 AM
gerritbot added a comment.Aug 5 2024, 9:58 AM

Change #1057997 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove uses of removed 'rememberpassword' preference

https://gerrit.wikimedia.org/r/1057997

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 5 2024, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2024, 10:30 AM
matmarex closed this task as Resolved.Aug 5 2024, 4:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits