git bisect finds the API BREAKING CHANGE (https://gerrit.wikimedia.org/r/#/c/227686/) is when this broke.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Fix keys for labels, descriptions & sites in JSON API | Addshore | mediawiki/extensions/Wikibase | master | +51 -17 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | jayvdb | T110559 Make sure that Pywikibot still works with new api data output format | |||
| Resolved | Addshore | T110668 PropertyId is not formatted with label when saving / adding new statements |
Event Timeline
Comment Actions
the serialization from wbgetentities is returned like:
{"entities":[{"pageid":122,"ns":122,"title":"Property:P31","lastrevid":122,"modified":"2015-08-03T22:06:39Z","type":"property","datatype":"wikibase-item","id":"P31","labels":[{"language":"en","value":"stated in"}],"descriptions":[{"language":"en","value":"to be used in the source field, to indicate where a claim is made"}],"aliases":{"en":[{"language":"en","value":"source of claim"}]},"claims":{}}],"success":1}
before, it was like:
{"entities":{"P31":{"pageid":122,"ns":122,"title":"Property:P31","lastrevid":122,"modified":"2015-08-03T22:06:39Z","type":"property","datatype":"wikibase-item","id":"P31","labels":{"en":{"language":"en","value":"stated in"}},"descriptions":{"en":{"language":"en","value":"to be used in the source field, to indicate where a claim is made"}},"aliases":{"en":[{"language":"en","value":"source of claim"}]}}},"success":1}
with "en" as a key for labels and other terms. The javascript code is expecting these.
Comment Actions
Change 234528 had a related patch set uploaded (by Addshore):
Fix keys for labels and descriptions in JSON API
Comment Actions
Change 234528 merged by jenkins-bot:
Fix keys for labels, descriptions & sites in JSON API
Comment Actions
wbsetlabel & wbsetdescription were broken too, see https://gerrit.wikimedia.org/r/235970.