Page MenuHomePhabricator
Create Task
Maniphest T110670

Incorrect tab highlighted on Special:SearchTranslations
Closed, ResolvedPublic
Actions

Description

To reproduce:

  1. Go to Special:SearchTranslations
  2. Type query with invalid filter such as "filter:foo user"

Observed:

  • List of untranslated messages are shown.
  • "Outdated translations" tab is selected

Expected:

  • Filter param is ignored
  • "Translations" tab is selected

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Ignore filter parameter on querying an invalid filter.mediawiki/extensions/Translatemaster+9 -4
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Aug 28 2015, 1:05 PM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a project: MediaWiki-extensions-Translate.
Nikerabbit subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2015, 1:05 PM
gerritbot subscribed.Sep 6 2015, 8:11 AM

Change 236406 had a related patch set uploaded (by Phoenix303):
Ignore filter parameter on querying an invalid filter.

https://gerrit.wikimedia.org/r/236406

gerritbot added a project: Patch-For-Review.Sep 6 2015, 8:12 AM
Nikerabbit assigned this task to Phoenix303.Sep 9 2015, 6:38 AM
Nikerabbit triaged this task as Low priority.
Nikerabbit moved this task from Backlog to search on the MediaWiki-extensions-Translate board.Sep 9 2015, 7:08 AM
gerritbot added a comment.Sep 10 2015, 2:51 PM

Change 236406 merged by jenkins-bot:
Ignore filter parameter on querying an invalid filter.

https://gerrit.wikimedia.org/r/236406

Diffusion mentioned this in rMEXTa848874e50b3: Updated mediawiki/extensions Project: mediawiki/extensions/Translate….Sep 10 2015, 2:51 PM
Phoenix303 mentioned this in rETRA15d5792e8324: Ignore filter parameter on querying an invalid filter..Sep 10 2015, 2:52 PM
Nemo_bis closed this task as Resolved.Sep 10 2015, 7:56 PM
Nemo_bis subscribed.

"filter:foo user" now gets stripped to "user" upon submit, a bit drastic but it works and is a transparent behaviour. Thanks!

ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 10 2015, 11:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits